New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Issue3652 - items readded to iOS ListView after they were removed aren't visible #4957

Closed
PureWeen opened this Issue Jan 11, 2019 · 0 comments

Comments

@PureWeen
Copy link
Contributor

PureWeen commented Jan 11, 2019

Description

Looks like this commit caused the issue
c10084f#diff-381c6c37e826f38028e8841495e4f78e

The changes with the LabelRenderer

Looks like we need to reset the perfect size check

		protected override void OnElementChanged(ElementChangedEventArgs<Label> e)
		{
			_perfectSizeValid = false;

2019-01-10_17-16-50

Steps to Reproduce

  1. Run Issue3652
  2. Remove the 3 items
  3. click add item

Notice they won't start showing up until they hit a place in the list view that has to create new cells

Expected Behavior

new items should be visible

Actual Behavior

new items aren't visible

Basic Information

  • Version with issue: 3.5
  • Last known good version: 3.4
  • IDE:
  • Platform Target Frameworks:
    • iOS: 12

@PureWeen PureWeen added this to the 3.5.0 milestone Jan 11, 2019

@PureWeen PureWeen added this to Ready in vNext (Target 3.5.0) via automation Jan 11, 2019

@PureWeen PureWeen added this to To do in Sprint 147 via automation Jan 11, 2019

@PureWeen PureWeen self-assigned this Jan 11, 2019

@samhouts samhouts moved this from Ready to In Progress in vNext (Target 3.5.0) Jan 11, 2019

@samhouts samhouts moved this from To do to Ready for Review (Issues) in Sprint 147 Jan 11, 2019

@samhouts samhouts moved this from In Progress to Done in vNext (Target 3.5.0) Jan 14, 2019

@samhouts samhouts moved this from Ready for Review (Issues) to Done in Sprint 147 Jan 14, 2019

@rmarinho rmarinho closed this in 60acae7 Jan 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment