Skip to content
This repository was archived by the owner on May 1, 2024. It is now read-only.

Conversation

@paymicro
Copy link
Contributor

Description of Change

Issues Resolved

partially fixes #4956 [Android]

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

Stepper don't skipped from with TabStop

Testing Procedure

  • Run Issue3872
  • Tab Over controls
  • You're able to tab to stepper

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@mattleibow
Copy link
Contributor

Just a note that this PR is included in the changes for material: #5027

@rmarinho rmarinho merged commit cd1cf19 into xamarin:master Feb 12, 2019
@paymicro paymicro deleted the fix-gh4956-tabstop-stepper branch February 12, 2019 14:23
PureWeen pushed a commit that referenced this pull request Feb 22, 2019
* [Android] [Material] Refactored the Stepper on Android #5011
 - reuse code between default and material
 - added material stepper

* [Android] [Material] Using the "Fast" renderer style for the stepper #5011
 - switched the button style to the outlined buttons

* [Android] [Material] Adding the tab stops support (#5000)

* [Android] [Material] Switching back to a traditional renderer for now to get tabstops working

* [Material] [iOS] Added a Material stepper for iOS

* [Material] [Android, iOS] Addressed the PR feedback

* [Material] Remove private

* Update MaterialStepperRenderer.cs

* Update StepperRendererManager.cs

* Fixed the merge issues

* add steppers to visual gallery

* The material stepper buttons now resize to fit the available space.

* Update Xamarin.Forms.Controls/ControlGalleryPages/VisualGallery.xaml

Co-Authored-By: mattleibow <mattleibow@live.com>

* [Material] [Stepper] Don't set the background color for steppers
 - we still need to decide on the logic behind the coloring of outline buttons

* Fixed the Android accessibility

* Change UI tests to not use a Text search for locating stepper controls
AndreiMisiukevich pushed a commit to AndreiMisiukevich/Xamarin.Forms that referenced this pull request Feb 25, 2019
@samhouts samhouts added this to the 3.6.0 milestone Mar 5, 2019
AxelUser pushed a commit to AxelUser/Xamarin.Forms that referenced this pull request Jun 15, 2019
@samhouts samhouts added the approved Has two approvals, no pending reviews, and no changes requested label Jul 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Has two approvals, no pending reviews, and no changes requested p/Android p/iOS 🍎 t/bug 🐛

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS,Android] TabStop skips Stepper Control

5 participants