Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xamarin.UWP app usually hangs when using narrator #5340

Closed
licanhua opened this issue Feb 21, 2019 · 1 comment
Closed

Xamarin.UWP app usually hangs when using narrator #5340

licanhua opened this issue Feb 21, 2019 · 1 comment

Comments

@licanhua
Copy link

@licanhua licanhua commented Feb 21, 2019

Description

Because we have wrong automation implementation for ListViewRenderer in Xamarin.Forms.Platform.UAP, it caused infinite loop in XAML framework. The problem is introduced by new ListViewAutomationPeer(List).

Concerned code is Xamarin.Forms.Platform.UAP/ListViewRenderer.cs

protected override AutomationPeer OnCreateAutomationPeer() { 
    return List == null ? new FrameworkElementAutomationPeer(this) : 
                    new ListViewAutomationPeer(List); 
}

If we have a Xamarin application and create a LIstView, The xaml tree is like this:
ListViewRender
ListView

When ListView AUtomationPeer ask for its parent, it points back to itself.
ListView AutomationPeer -> ListViewRender AutomationPeer -> ListView AutomationPeer -> ListViewRender AutomationPeer.

Steps to Reproduce

It's tracked by internal Bug 20500989

Expected Behavior

Actual Behavior

app has no response

Basic Information

  • Version with issue:
  • Last known good version:
  • IDE:
  • Platform Target Frameworks:
    • iOS:
    • Android:
    • UWP:
  • Android Support Library Version:
  • Nuget Packages:
  • Affected Devices:

Screenshots

Reproduction Link

@licanhua licanhua added the t/bug 🐛 label Feb 21, 2019
@pauldipietro pauldipietro added this to New in Triage Feb 21, 2019
@samhouts samhouts moved this from New to Ready For Work in Triage Mar 2, 2019
@samhouts samhouts added this to To do in UWP Ready For Work Mar 2, 2019
@samhouts samhouts removed this from Ready For Work in Triage Mar 2, 2019
@NavaneethS

This comment has been minimized.

Copy link

@NavaneethS NavaneethS commented May 7, 2019

I also face the same issue. With the Narrator open, if we click any of the ListView elements the app hangs and never responds. Although it is not consistent. The sample is attached.

ListViewNarrator.zip

@samhouts samhouts added this to To do in Sprint 153 May 20, 2019
@samhouts samhouts moved this from To do to Continued in next sprint in Sprint 153 Jun 1, 2019
@samhouts samhouts added this to To do in Sprint 154 via automation Jun 1, 2019
@paymicro paymicro self-assigned this Jun 6, 2019
@paymicro paymicro mentioned this issue Jun 6, 2019
1 of 3 tasks complete
@samhouts samhouts added this to In Progress in v4.1.0 Jun 6, 2019
@samhouts samhouts moved this from To do to Ready for Review (Issues) in Sprint 154 Jun 6, 2019
@samhouts samhouts moved this from In Progress to Done in v4.1.0 Jun 20, 2019
@samhouts samhouts moved this from Ready for Review (Issues) to Done in Sprint 154 Jun 20, 2019
@samhouts samhouts closed this in ec5645a Jun 21, 2019
UWP Ready For Work automation moved this from To do to Done Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Sprint 153
  
Continued in next sprint
Sprint 154
  
Done
v4.1.0
  
Done
5 participants
You can’t perform that action at this time.