Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shell] Cannot navigate to a route #5466

Closed
davidortinau opened this issue Mar 6, 2019 · 0 comments

Comments

Projects
5 participants
@davidortinau
Copy link
Contributor

commented Mar 6, 2019

Description

No matter what I try to navigate to by URI, I get this error:

System.NotImplementedException: The method or operation is not implemented.
  at Xamarin.Forms.Shell.GoToAsync (Xamarin.Forms.ShellNavigationState state, System.Boolean animate) [0x000d8] in D:\a\1\s\Xamarin.Forms.Core\Shell\Shell.cs:382 
  at Demos.ViewModels.DemoViewModel.HandleVisualNav (System.String page) [0x00035] in /work/TheLittleThingsPlayground/TheLittleThingsPlayground/ViewModels/DemoViewModel.cs:35 

In AppShell.xaml.cs I register the route like this:

Routing.RegisterRoute("buttons", typeof(ButtonsPage));

And then in the VM call the GoToAsync (page is "buttons"):

await Shell.CurrentShell.GoToAsync($"{page}", true);

I've also tried:

await Shell.CurrentShell.GoToAsync($"app://root/ShellItem14/three_six/{page}", true);
await Shell.CurrentShell.GoToAsync($"app:///ShellItem14/three_six/{page}", true);
await Shell.CurrentShell.GoToAsync($"/{page}", true);

Thinking I could use the relative navigation that @paymicro added in #4977 .

Basic Information

  • Version with issue: 3.6.0.220655

Reproduction

https://github.com/davidortinau/TheLittleThingsPlayground/blob/3.6.0/TheLittleThingsPlayground/ViewModels/DemoViewModel.cs#L35

@pauldipietro pauldipietro added this to New in Triage Mar 6, 2019

@paymicro paymicro self-assigned this Mar 6, 2019

@paymicro paymicro referenced this issue Mar 7, 2019

Merged

[shell] Fix show DisplayAlert #5491

0 of 3 tasks complete

@kingces95 kingces95 moved this from New to Ready For Work in Triage Mar 7, 2019

rmarinho added a commit that referenced this issue Mar 8, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Mar 8, 2019

@samhouts samhouts removed this from Ready For Work in Triage Mar 11, 2019

rmarinho added a commit that referenced this issue Mar 14, 2019

@rmarinho rmarinho referenced this issue Mar 14, 2019

Merged

[Shell] Fix Register route and Navigate to it #5564

0 of 3 tasks complete

@samhouts samhouts added this to In Progress in v3.6.0 Mar 14, 2019

@PureWeen PureWeen added this to the 4.0.0 milestone Mar 22, 2019

@samhouts samhouts removed this from In Progress in v3.6.0 Mar 22, 2019

@samhouts samhouts added this to In Progress in v3.6.0 Mar 24, 2019

@samhouts samhouts added the e/8 🕗 label Mar 25, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.6.0 Mar 25, 2019

@samhouts samhouts added this to To do in Sprint 151 Mar 25, 2019

@samhouts samhouts removed this from In Progress in vCurrent (4.0.0) Mar 25, 2019

@PureWeen PureWeen assigned rmarinho and unassigned paymicro Mar 25, 2019

@PureWeen PureWeen moved this from To do to Ready for Review (Issues) in Sprint 151 Mar 25, 2019

rmarinho added a commit that referenced this issue Mar 26, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Mar 27, 2019

rmarinho added a commit that referenced this issue Mar 27, 2019

[Shell] Add FlyoutIcon (#5567) fixes #4766 fixes #4767 fixes #4845 fixes
 #5219

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [iOS,Shell] Fix issue when disposing ToolbarItems  of old page

* [Controls] Add demo repo for #5466

* [Shell,Core] Fix navigating to a registered route

* [Shell,Core] Add better exception messages for wrong or non existing content fixes #5081

* [Core,Shell,iOS,Android] Add FlyoutIcon property

* [Controls] Make shell sample work on Android

* [Controls,Android] Add ImageSource support to FlyoutIcon

* [Android]Allow to set text on the back button

* [Android] Create default text back button

* [Controls] Add example to push with back button behavior

* [Android] Fix back button tint color

* [Android] Cleanup and refactor UpdateDrawerArrow

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior

* [iOS] Check the ParentViewController since we were push to it

* [Android,iOS,Shell] Remove extra code implement feedback

* removed old code

* minor cleanup

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Mar 27, 2019

@samhouts samhouts closed this in 7118af9 Mar 28, 2019

Sprint 151 automation moved this from Ready for Review (Issues) to Done Mar 28, 2019

@samhouts samhouts removed this from the 3.6.0 milestone Apr 18, 2019

@samhouts samhouts moved this from In Progress to Closed in v3.6.0 Apr 22, 2019

AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this issue Jun 15, 2019

[Shell] Fix Register route and Navigate to it (xamarin#5564) fixes xa…
…marin#5466

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [Shell,iOS] Fix toolbaritems on Shell

* [Controls] Add demo repo for xamarin#5466

* [Shell,Core] Fix navigating to a registered route

* [Controls] Fix android example add missing images

* nested routing

* [Controls] Fix build on pre app compact

AxelUser added a commit to AxelUser/Xamarin.Forms that referenced this issue Jun 15, 2019

[Shell] Add FlyoutIcon (xamarin#5567) fixes xamarin#4766 fixes xamari…
…n#4767 fixes xamarin#4845 fixes xamarin#5219

* [Controls]  Add repo for shell issue

* [iOS] Allow specify SetPaddingInsets on the ShellContent

* [iOS,Shell] Fix issue when disposing ToolbarItems  of old page

* [Controls] Add demo repo for xamarin#5466

* [Shell,Core] Fix navigating to a registered route

* [Shell,Core] Add better exception messages for wrong or non existing content fixes xamarin#5081

* [Core,Shell,iOS,Android] Add FlyoutIcon property

* [Controls] Make shell sample work on Android

* [Controls,Android] Add ImageSource support to FlyoutIcon

* [Android]Allow to set text on the back button

* [Android] Create default text back button

* [Controls] Add example to push with back button behavior

* [Android] Fix back button tint color

* [Android] Cleanup and refactor UpdateDrawerArrow

* Update Xamarin.Forms.Platform.Android/Renderers/ShellToolbarTracker.cs

Co-Authored-By: rmarinho <me@ruimarinho.net>

* [iOS,Shell] Fix go back (Pop) when proving BackButtonBehavior

* [iOS] Check the ParentViewController since we were push to it

* [Android,iOS,Shell] Remove extra code implement feedback

* removed old code

* minor cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.