Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] ListView HasUnevenRows is not working in iOS 10 #5888

Closed
msangtarash opened this issue Apr 11, 2019 · 3 comments

Comments

Projects
4 participants
@msangtarash
Copy link

commented Apr 11, 2019

Description

HasUnevenRows doesn't work in iOS version 10.3 while Xamarin forms version is the latest (3.6.0.293080) ,but it works fine in other versions of iOS and Xamarin forms.

Steps to Reproduce

  1. Add a listView
  2. Set HasUnevenRows to true
  3. Size of row cells in listView doesn't change automatically.
       <ListView  
            HasUnevenRows="True">
            <ListView.ItemTemplate>
                <DataTemplate>
                    <ViewCell>
                        <StackLayout>
                            <Label Text="Hi" />
                            <Label Text="bye" />
                            <Label Text="Open" />
                        </StackLayout>
                    </ViewCell>
                </DataTemplate>
            </ListView.ItemTemplate>
            <ListView.ItemsSource>
                <x:Array Type="{x:Type x:String}">
                    <x:String>mono</x:String>
                    <x:String>monodroid</x:String>
                </x:Array>
            </ListView.ItemsSource>
        </ListView>

Basic Information

  • Version with issue: Xamarin Forms 3.6.0.293080
  • IDE: Visual Studio 2019 (16.0.1)
  • Platform Target Frameworks :
    iOS: 10.3

Reproduction Link

Sample.zip

@samhouts

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Well, the missing padding is also a little weird. Here's 3.6.0 SR1:
image
And 3.6.0 SR2:
image

@samhouts samhouts added e/1 🕐 and removed s/unverified labels Apr 12, 2019

@samhouts samhouts added this to the 3.6.0 milestone Apr 12, 2019

@samhouts samhouts added this to To do in Sprint 151 via automation Apr 12, 2019

@samhouts samhouts moved this from New to Ready For Work in Triage Apr 12, 2019

@brandonyoung

This comment has been minimized.

Copy link

commented Apr 13, 2019

Downgrading to Xamarin.Forms 3.6.0.220655 resolved the issue. Anything higher still had the issue.

@samhouts samhouts added this to To do in v3.6.0 Apr 15, 2019

@samhouts samhouts added this to To do in iOS Ready For Work Apr 18, 2019

@samhouts samhouts removed this from Ready For Work in Triage Apr 18, 2019

@melimion

This comment has been minimized.

Copy link

commented Apr 18, 2019

@samhouts, issue is in this line

if (estimatedRowheight == 0 && Forms.IsiOS11OrNewer)

can be fixed by changing to

if (estimatedRowheight>0 || estimatedRowheight == 0 && IsiOS11OrNewer)

@samhouts samhouts added this to To do in Sprint 152 via automation Apr 22, 2019

samhouts added a commit that referenced this issue May 10, 2019

Add repro for #5888
Co-Authored-By: melimion <melimion@users.noreply.github.com>

@samhouts samhouts moved this from To do to In Progress in v3.6.0 May 11, 2019

@samhouts samhouts moved this from To do to Ready for Review (Issues) in Sprint 152 May 11, 2019

@samhouts samhouts closed this in 71c62a5 May 11, 2019

v3.6.0 automation moved this from In Progress to Closed May 11, 2019

iOS Ready For Work automation moved this from To do to Done May 11, 2019

Sprint 152 automation moved this from Ready for Review (Issues) to Done May 11, 2019

@samhouts samhouts moved this from Closed to Done in v3.6.0 May 11, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) May 14, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) May 16, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 4, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 4, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 4, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 5, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 6, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 6, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 6, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 6, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 6, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 6, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 7, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 7, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 7, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 8, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 8, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 10, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 10, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 10, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 10, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 11, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 11, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 12, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts added this to In Progress in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) Jun 13, 2019

@samhouts samhouts removed this from Done in vCurrent (4.0.0) Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.