Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] [Forms 4.0] [Android] Mismatch in WebView.EnableZoomControls platform-specific #6130

Closed
davidbritch opened this issue May 8, 2019 · 0 comments

Comments

@davidbritch
Copy link
Collaborator

commented May 8, 2019

Description

In Forms 4.0, it's impossible to consume the WebView.EnableZoomControls platform-specific (Android) in XAML (PR: #3607), due to a mistmatch in this line:

public static readonly BindableProperty EnableZoomControlProperty = BindableProperty.Create("EnableZoomControls", typeof(bool), typeof(FormsElement), false);

If you try to consume EnableZoomControls in XAML it errors as the BP isn't named that. If you try to consume EnableZoomControl in XAML it errors because there isn't a public getter that matches it.

@pauldipietro pauldipietro added this to New in Triage May 8, 2019

@davidbritch davidbritch changed the title [Bug] [Android] Mismatch in WebView.EnableZoomControls platform-specific [Bug] [Forms 4.0] [Android] Mismatch in WebView.EnableZoomControls platform-specific May 8, 2019

@samhouts samhouts self-assigned this May 8, 2019

@samhouts samhouts removed the s/unverified label May 8, 2019

@samhouts samhouts added this to the 4.0.0 milestone May 8, 2019

@samhouts samhouts added this to To do in vCurrent (4.0.0) May 8, 2019

@samhouts samhouts added the e/1 🕐 label May 8, 2019

samhouts added a commit that referenced this issue May 8, 2019

samhouts added a commit that referenced this issue May 8, 2019

@samhouts samhouts moved this from To do to In Progress in vCurrent (4.0.0) May 8, 2019

@samhouts samhouts removed this from New in Triage May 8, 2019

@samhouts samhouts closed this in a542264 May 10, 2019

@samhouts samhouts moved this from In Progress to Done in vCurrent (4.0.0) May 10, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.