Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Vertical orientation for IndicatorView #8977

Open
andreas-nesheim opened this issue Dec 19, 2019 · 0 comments
Open

[Enhancement] Vertical orientation for IndicatorView #8977

andreas-nesheim opened this issue Dec 19, 2019 · 0 comments

Comments

@andreas-nesheim
Copy link
Contributor

@andreas-nesheim andreas-nesheim commented Dec 19, 2019

Summary

It would be nice to select a vertical orientation for the new IndicatorView. As of now it is horizontal and stuck at the bottom of the page.

API Changes

A new bindable property named "Orientation" should be added to the IndicatorView.

var indicatorView = new IndicatorView();
indicatorView.Orientation = IndicatorViewOrientation.Vertical; // new API

For Android I tested the possibility of this with a custom renderer. Setting the LinearLayout.Orientation = Orientation.Vertical had some results, but I also had to set the HeightRequest in XAML to make sure the results actually worked.

Intended Use Case

This would open up for having the IndicatorView f.ex. fixed to the right or left side of the page and would make more sense for vertical scrolling of a CarouselView.

I'm picturing something like this (results of fiddling with a custom renderer):

indicatorview-vertical-scaled

@pauldipietro pauldipietro added this to New in Triage Dec 19, 2019
@rmarinho rmarinho moved this from New to Needs Estimate in Triage Dec 20, 2019
@samhouts samhouts removed this from Needs Estimate in Triage Jan 3, 2020
@samhouts samhouts added this to Under consideration in Enhancements Jan 28, 2020
@samhouts samhouts added this to Backlog in IndicatorView Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Enhancements
  
Under consideration
IndicatorView
  
Backlog
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.