Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

[Android] Fix issue using HideSingle property on IndicatorView #11072

Merged
merged 3 commits into from
Jul 3, 2020
Merged

[Android] Fix issue using HideSingle property on IndicatorView #11072

merged 3 commits into from
Jul 3, 2020

Conversation

jsuarezruiz
Copy link
Contributor

Description of Change

Implement HideSingleIndicatorView property on Android.

Issues Resolved

API Changes

None

Platforms Affected

  • Android

Behavioral/Visual Changes

None

Before/After Screenshots

Before

HideSingle has no effect on Android.

After

fix11018

Testing Procedure

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts requested review from hartez and samhouts June 23, 2020 22:52
@samhouts samhouts changed the base branch from 4.6.0 to 4.7.0 June 25, 2020 22:25
@rmarinho
Copy link
Member

rmarinho commented Jul 2, 2020

@jsuarezruiz buid is failing

  D:\agent\1\s\Xamarin.Forms.Controls.Issues\Xamarin.Forms.Controls.Issues.Shared\Issue11018.cs(25,57): error CS0117: 'ExperimentalFlags' does not contain a definition for 'IndicatorViewExperimental' [D:\agent\1\s\Xamarin.Forms.Controls\Xamarin.Forms.Controls.csproj]

@rmarinho rmarinho added the DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. label Jul 2, 2020
@rmarinho rmarinho merged commit 3f6ae8f into 4.7.0 Jul 3, 2020
@rmarinho rmarinho deleted the fix-11018 branch July 3, 2020 14:03
@samhouts samhouts modified the milestones: 4.8.0, 4.7.0 Jul 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hartez hartez hartez approved these changes

@rmarinho rmarinho rmarinho approved these changes

@samhouts samhouts Awaiting requested review from samhouts

Assignees

@hartez hartez

@samhouts samhouts

Labels
a/carouselview a/collectionview a/indicatorview DO-NOT-MERGE-!!! 🛑 This is in progress and needs to be updated before it can be merged. p/Android p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
4.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jsuarezruiz @rmarinho @hartez @samhouts