This repository has been archived by the owner on May 1, 2024. It is now read-only.
Create a specific XAML page for the ShellPageWrapper used for Shell Navigation #11766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samhouts
added
ControlGallery
p/UWP
a/shell 🐚
4.8.0
PureWeen
commented
Aug 12, 2020
| @@ -19,6 +19,8 @@ public static IApp ConfigureApp() | |||
| { | |||
| if (Session == null) | |||
| Session = CreateWindowsDriver(); | |||
| else | |||
| Reset(); | |||
There was a problem hiding this comment.
If user gets here but the app is already running then they want it reset to the first page. This is how android/ios work
PureWeen
commented
Aug 12, 2020
| @@ -573,7 +581,19 @@ public CoreRootPage(Page rootPage, NavigationBehavior navigationBehavior = Navig | |||
| Command = new Command(async () => | |||
| { | |||
| if (!string.IsNullOrEmpty(searchBar.Text)) | |||
| await corePageView.PushPage(searchBar.Text); | |||
| { | |||
| if(!(await corePageView.PushPage(searchBar.Text))) | |||
There was a problem hiding this comment.
All the gallery code added is to enable navigating to store shell from the root page of the gallery
PureWeen
commented
Aug 12, 2020
| @@ -193,12 +193,12 @@ steps: | |||
| TargetFolder: ${{ parameters.artifactsTargetFolder }} | |||
|
|
|||
| - script: build.cmd -Target cg-uwp-build-tests -ScriptArgs '-BUILD_CONFIGURATION="$(BuildConfiguration)"' | |||
| condition: eq(variables['BuildConfiguration'], 'Debug') | |||
| condition: and(eq(variables['BuildConfiguration'], 'Release'), ne('${{ parameters.includePages }}', true)) | |||
There was a problem hiding this comment.
none of these steps are useful to the pages build lane
PureWeen
commented
Aug 12, 2020
| .WithRestore() | ||
| ); | ||
|
|
||
| MSBuild("Xamarin.Forms.Core.Windows.UITests\\Xamarin.Forms.Core.Windows.UITests.csproj", | ||
| GetMSBuildSettings().WithRestore()); | ||
| GetMSBuildSettings(buildConfiguration:"Debug").WithRestore()); |
There was a problem hiding this comment.
There's no reason to build the UI Tests themselves with a release configuration
|
Test failures unrelated |
|
iOS and Android failures unrelated |
samhouts
approved these changes
Aug 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Issues Resolved
Platforms Affected
Testing Procedure
PR Checklist