Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Microsoft.NETCore.UniversalWindowsPlatform From nuspec #11939

Merged
merged 1 commit into from Aug 27, 2020

Conversation

PureWeen
Copy link
Contributor

Description of Change

The version of Microsoft.NETCore.UniversalWindowsPlatform should be settable by the application developer. By default we'll have our templates always pointing at the latest tested version

Having this in our nuspec and inside the templates just leads to nuget dependency confusions

Platforms Affected

  • UWP

Testing Procedure

  • UI tests pass
  • make sure you can install this nuget into a new UWP app and it runs

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@samhouts samhouts added the p/UWP label Aug 27, 2020
@samhouts samhouts added this to In Review in vCurrent (4.8.0) Aug 27, 2020
@rmarinho rmarinho merged commit e0e7548 into 4.8.0 Aug 27, 2020
vCurrent (4.8.0) automation moved this from In Review to Done Aug 27, 2020
@rmarinho rmarinho deleted the remove_uwp_build_package_from_nuspec branch August 27, 2020 08:37
@samhouts samhouts added this to Done in Sprint 175 Aug 27, 2020
@samhouts samhouts added this to the 4.8.0 milestone Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants