Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Check for SelectedIndex value in OnEnded #1278

Merged
merged 1 commit into from Dec 5, 2017
Merged

Conversation

@pauldipietro
Copy link
Member

pauldipietro commented Nov 15, 2017

Description of Change

While looking into a separate issue, a scenario was found where an empty Picker could be tapped/swiped at and then closed, causing a crash in OnEnded as it attempts to select row -1.

The Picker page in the gallery is empty by default; attempting to reproduce the issue without this fix should cause a crash there.

Bugs Fixed

N/A

API Changes

None

Behavioral Changes

I don't believe this should affect the original fix from #1054; only the scenario where the list is empty and nothing is selected.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho rmarinho merged commit c2f348a into master Dec 5, 2017
9 of 12 checks passed
9 of 12 checks passed
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS9 Validation UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Xamarin Forms OSX pull-1278 - (1144489) Succeeded
Details
VSTS: Xamarin Forms Windows 1144489 Succeeded
Details
VSTS: Xamarin Forms Windows (PR Builds) Started PR process $(TriggeredBuildIds)
Details
VSTS: iOS10 Validation UITests Finished
Details
@rmarinho rmarinho deleted the picker-onended-crash branch Dec 5, 2017
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Aug 23, 2019
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.