New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xaml[C]] avoid processing nested RD multiple times #1300

merged 1 commit into from Nov 29, 2017


None yet
4 participants

StephaneDelcroix commented Nov 22, 2017

Description of Change

With changes introduced to FillRDVisitor, it can happen that nested RD are processed multiple times, hence creating duplicate keys. This prevents that.

NOTE0: this PR is against the 2.5.0 branch. once merged, it needs to be merged back to master.
NOTE1: should be included in next -sr

Bugs Fixed

API Changes


Behavioral Changes


PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master 15-5 at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

This comment has been minimized.

Show comment
Hide comment

StephaneDelcroix Nov 22, 2017


don't bother about the CI failing. it's CI's cause


StephaneDelcroix commented Nov 22, 2017

don't bother about the CI failing. it's CI's cause

@samhouts samhouts added the D-15.5 label Nov 22, 2017

@jassmith jassmith merged commit 2f84a94 into 15-5 Nov 29, 2017

0 of 2 checks passed

VSTS: Xamarin Forms Windows 1164901 Failed
VSTS: Xamarin Forms Windows (PR Builds) Started PR process $(TriggeredBuildIds)

@samhouts samhouts added this to the 2.5.0 milestone May 5, 2018

@StephaneDelcroix StephaneDelcroix deleted the fix-bz60788 branch May 8, 2018

@samhouts samhouts modified the milestones: 2.5.0, 2.3.0 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment