Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all the UIViews in iOS are added at the correct hierarchy #13300

Merged
merged 2 commits into from Jan 7, 2021
Merged

Make sure all the UIViews in iOS are added at the correct hierarchy #13300

merged 2 commits into from Jan 7, 2021

Conversation

PureWeen
Copy link
Contributor

@PureWeen PureWeen commented Jan 6, 2021

Description of Change

With the Shell Flyout Content PR the Flyout Content started getting inserted behind the FlyoutBackground Image. These changes ensure that all the UIView's that are part of Flyout Content more deterministically get inserted into the Flyout

Issues Resolved

Platforms Affected

  • iOS

Testing Procedure

  • included UI Tests for some offset validation
  • When the background image overlaps the content the content is still clickable so there isn't a great way to automate the test

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@PureWeen PureWeen added the blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. label Jan 6, 2021
@PureWeen PureWeen added this to the 5.0.0 milestone Jan 6, 2021
@PureWeen PureWeen added this to To do in vNext+1 (5.0.0) via automation Jan 6, 2021
@PureWeen PureWeen requested a review from rmarinho January 6, 2021 03:55
pictos
pictos approved these changes Jan 7, 2021
View reviewed changes
Copy link
Contributor

@pictos pictos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@rmarinho rmarinho merged commit ec380e4 into 5.0.0 Jan 7, 2021
vNext+1 (5.0.0) automation moved this from To do to Done Jan 7, 2021
@rmarinho rmarinho deleted the fix_13295 branch January 7, 2021 13:07
Braini01 pushed a commit to Braini01/Xamarin.Forms that referenced this pull request Jan 8, 2021
@github-actions
Automated dotnet-format update (xamarin#13297)
669221c 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

Make sure all the UIViews is iOS are added at the correct hierarchy (xamarin#13300) fixes xamarin#13295

* Fix layout of FlyoutContent

* - fix ui tests
@PureWeen PureWeen mentioned this pull request Jan 26, 2021
Open
@PureWeen PureWeen changed the title Make sure all the UIViews is iOS are added at the correct hierarchy Make sure all the UIViews in iOS are added at the correct hierarchy May 24, 2021
@b-wind b-wind mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmarinho rmarinho rmarinho approved these changes

@pictos pictos pictos approved these changes

@HxYxI HxYxI HxYxI approved these changes

Assignees
No one assigned
Labels
blocker Issue blocks next stable release. Prioritize fixing and reviewing this issue. t/bug 🐛
Projects
No open projects
vNext+1 (5.0.0)
Done
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

[Bug] Flyout Items not Visible on Shell when you are using a Flyout Background Image or a Brush
5 participants
@PureWeen @rmarinho @pictos @HxYxI @samhouts