Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add API condition for initialize LayoutDirection #1388

Merged
merged 11 commits into from Dec 15, 2017

Conversation

@mohachouch
Copy link
Collaborator

mohachouch commented Dec 12, 2017

Description of Change

The android platform crash when launching in the API15 and API16 versions because the property LayoutDirection is available since API17.

See Android docs : https://developer.android.com/reference/android/content/res/Configuration.html#getLayoutDirection()

API Changes

None

Beehavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
mohachouch added 11 commits Oct 25, 2017
Sync Master with origin
Sync with origin
Rebase Master
Rebase with master
Rebase master
Rebase master
Rebase master
Rebase Master
Rebase master
@rmarinho rmarinho requested a review from samhouts Dec 12, 2017
@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Dec 12, 2017

build

Copy link
Member

rmarinho left a comment

Failing tests not related

@rmarinho rmarinho merged commit eaeab9b into xamarin:master Dec 15, 2017
8 of 13 checks passed
8 of 13 checks passed
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS9 Validation UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Xamarin Forms (PR Builds) Started PR process
Details
VSTS: Xamarin Forms OSX pull-1388 - (1218081) succeeded
Details
VSTS: Xamarin Forms Windows VS2017 PR-1388 - (1218081) succeeded
Details
license/cla All CLA requirements met.
jsuarezruiz added a commit to jsuarezruiz/Xamarin.Forms that referenced this pull request Dec 21, 2017
* 'master' of https://github.com/xamarin/Xamarin.Forms: (53 commits)
  Add implicit color conversion to .NET Standard's System.Drawing.Color (xamarin#1359)
  [WPF, GTK, TIZEN] Replace obsolete OutlineColor by BorderColor (xamarin#1443)
  Stylesheets (xamarin#1207)
  [WPF] Add Deserializer implementation (xamarin#1411)
  [Build]Update provisioning submodule
  [Build] Update provisioning
  [UWP] Optimized ZIndexing for a thirty-nine percent speed boot on loa… (xamarin#1196)
  [Xaml] execute XamlG and XamlC on UWP SAP (xamarin#1391)
  [iOS] Update status bar color while page is appearing (xamarin#1288)
  Add condition SdkInt >= JellyBeanMr1 for set flow direction (xamarin#1388)
  Use GlobalAssemblyInfo on tizen backend (xamarin#1397)
  [Build] Bump to 15.5.2
  revert part of xamarin#1370. keep the test project out of netstandard for now (xamarin#1402)
  fix typo in csproj
  Fix for netstandard projects (xamarin#1382)
  [Xaml] open the api for loading xaml from string (xamarin#1394)
  [Android] Prevent a custom Entry/Editor Drawable from modifying non-custom ones (xamarin#1197)
  [build] force build on vs2015
  Add Xamarin.Forms.ControlGallery.Tizen project (xamarin#1389)
  Move XF.Build.Tasks to nestandard2.0 (xamarin#1370)
  ...
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.