This repository has been archived by the owner on May 1, 2024. It is now read-only.
[GTK] Some Shapes API support #14235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported Shapes: - Ellipse - Rectangle - Path Supported Path Segments: - Arc - Line Supported Brushes: - SolidColorBrush Co-authored-by: Afshin Arani <afshinarani79@gmail.com>
knocte
added a commit
to nblockchain/DotNetForms
that referenced
this pull request
May 2, 2021
Supported Shapes: - Ellipse - Rectangle - Path Supported Path Segments: - Arc - Line Supported Brushes: - SolidColorBrush Upstream PR: xamarin#14235 Co-authored-by: Afshin Arani <afshinarani79@gmail.com>
|
@knocte Looks nice, thanks for the contribution. Do you think could be possible to include Polyline and Polygon to have a PR including support to all the basic shapes at the same time? |
jsuarezruiz
added
the
s/needs-info ❓
Newly added shapes:
- Polygon
- Polyline
This commit also completes the support for
solid-color stroking.
@jsuarezruiz we have just pushed a 2nd commit that implements this. |
knocte
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Supported Shapes:
Supported Path Segments:
Supported Brushes:
(Strokes implementation will come in a 2nd PR.)
Co-authored-by: Afshin Arani <afshinarani79@gmail.com>
API Changes
NOTE: even if this could be considered an enhancement, any code that used Shapes with XamarinForms5.0 (or older) running on Gtk would have crashed or contained bugs (obviously), so this is essentially a bugfix. So: None, no API changes.
Platforms Affected
Testing Procedure
Manual with our own app.
PR Checklist