Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Layouts to specify whether child controls inherit InputTransparent #1621

Merged
merged 11 commits into from Feb 1, 2018

Conversation

@hartez
Copy link
Member

hartez commented Jan 19, 2018

Description of Change

By default, if a Layout is marked InputTransparent, its child controls are also InputTransparent. However, in some scenarios this behavior may not be desirable (e.g., control overlays). This change adds a boolean InputTransparentInherited. When set to true (the default), a Layout's child controls are InputTransparent when the Layout is InputTransparent. When set to false, the Layout's child controls are InputTransparent only if that property is explicitly set.

Bugs Fixed

API Changes

Added:
Xamarin.Forms.Layout

  • bool InputTransparentInherited { get; set; }
  • BindableProperty InputTransparentInheritedProperty

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
hartez added 11 commits Jan 3, 2018
Add InputTransparentInherited to VisualElement;
Handle InputTransparentInherited for Android;
Copy link
Member

rmarinho left a comment

Seems to work as expected, tested iOS and Android

@hartez

This comment has been minimized.

Copy link
Member Author

hartez commented Jan 31, 2018

Added do-not-merge tag - I want to change the name of InputTransparentInherited.

@PureWeen

This comment has been minimized.

Copy link
Contributor

PureWeen commented Feb 1, 2018

Looks good on UWP

@rmarinho rmarinho merged commit 85334fd into master Feb 1, 2018
13 checks passed
13 checks passed
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Xamarin Forms (PR Builds) Succeeded PR process
Details
VSTS: Xamarin Forms OSX PR-1621 - (1311707) succeeded
Details
VSTS: Xamarin Forms Windows VS2017 PR-1621 - (1311644) succeeded
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS9 Validation UITests Finished
Details
license/cla All CLA requirements met.
Details
@rookiejava rookiejava mentioned this pull request Feb 19, 2018
3 of 4 tasks complete
@hartez hartez deleted the inputtransparent-scope branch Mar 21, 2018
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.3.0 Jun 27, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Aug 23, 2019
@samhouts samhouts modified the milestones: 2.5.0, 3.0.0 Aug 23, 2019
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.