Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GetHandlerForObject instead of GetHandler #1713

Merged
merged 2 commits into from Jan 30, 2018

Conversation

praeclarum
Copy link
Contributor

@praeclarum praeclarum commented Jan 26, 2018

Description of Change

Replace remaining uses of GetHandler with GetHandlerForObject so that IReflectableTypes can be used.

This is work that should have been done in #1006 but was missed.

Bugs Fixed

API Changes

Added:

  • public T Registrar.GetHandlerForObject<T>(obj, args)

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

This allows IReflectableTypes to be used.
@praeclarum
Copy link
Contributor Author

I cannot see the build errors. Can someone post them?

@StephaneDelcroix
Copy link
Member

I cannot see the build errors. Can someone post them?

you forgot to update the docs

@jamesmontemagno
Copy link
Contributor

@StephaneDelcroix can you point to specifically where?

@praeclarum
Copy link
Contributor Author

Ah looks like I need to do something like 7cd583a

@StephaneDelcroix
Copy link
Member

@jamesmontemagno for the added API. There are scripts in the repository to generate the docs. you then only commit the meaningful changes. On a mac, I do make docs.

@StephaneDelcroix StephaneDelcroix merged commit e07e446 into xamarin:master Jan 30, 2018
jassmith pushed a commit that referenced this pull request Feb 21, 2018
* Use GetHandlerForObject instead of GetHandler

This allows IReflectableTypes to be used.

* Update Registrar docs

- fixes #1712
@samhouts samhouts added this to the 2.5.1 milestone May 5, 2018
@samhouts samhouts modified the milestones: 2.5.1, 2.5.0 Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IReflectableType not used when creating Android renderers
4 participants