Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check IsEnabled on TextCell before executing command #1889

Merged
merged 1 commit into from Feb 15, 2018

Conversation

@hartez
Copy link
Member

hartez commented Feb 15, 2018

Description of Change

Adds a check for IsEnabled before executing a Command from a TextCell.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho rmarinho merged commit a248ee5 into master Feb 15, 2018
12 of 13 checks passed
12 of 13 checks passed
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Xamarin Forms (PR Builds) Succeeded PR process
Details
VSTS: Xamarin Forms OSX PR-1889 - (1386577) succeeded
Details
VSTS: Xamarin Forms Windows VS2017 PR-1889 - (1386533) succeeded
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS9 Validation UITests Finished
Details
license/cla All CLA requirements met.
Details
@kicsiede

This comment has been minimized.

Copy link
Contributor

kicsiede commented Feb 15, 2018

after this change i am still able to select a "disabled" row on iOS (it gets highlighted), although the tap event is not raised indeed.

@hartez hartez deleted the fix-bugzilla60045 branch Mar 21, 2018
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.3.0 Jun 27, 2018
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Aug 23, 2019
@samhouts samhouts modified the milestones: 3.0.0, 2.5.0 Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.