Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fixed leaking reference to popped Page in PopAsync() #2092

Merged
merged 2 commits into from Mar 16, 2018
Merged

[Core] Fixed leaking reference to popped Page in PopAsync() #2092

merged 2 commits into from Mar 16, 2018

Conversation

rmarinho
Copy link
Member

@rmarinho rmarinho commented Mar 13, 2018 •
edited by samhouts

Description of Change

This is #1818 but user didn't rebase for 15-5

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@kicsiede @rmarinho
BUGFIX: leaking reference to popped Page in PopAsync()
29ad85f 
fixed by using a private wait handle the same way as when there is a pending task
@kicsiede @rmarinho
Update NavigationUnitTest.cs
a2fee1d
@rmarinho rmarinho mentioned this pull request Mar 13, 2018
Closed
4 tasks
@rmarinho rmarinho changed the title Fix bugzilla 31171 [Core] Fixed leaking reference to popped Page in PopAsync() Mar 13, 2018
@samhouts samhouts added this to Ready in v3.0.0 via automation Mar 14, 2018
@rmarinho
Copy link
Member Author

Failed tests are not related.

@rmarinho rmarinho requested review from samhouts and removed request for jassmith March 14, 2018 19:24
@StephaneDelcroix
Copy link
Member

do not Squash-Merge this to keep author information.

@rmarinho rmarinho moved this from Ready to In Review in v3.0.0 Mar 15, 2018
@rmarinho rmarinho merged commit c12ba7e into 15-5 Mar 16, 2018
v3.0.0 automation moved this from In Review to Done Mar 16, 2018
@samhouts samhouts added this to the 2.5.1 milestone May 5, 2018
@samhouts samhouts removed this from Done in v3.0.0 May 7, 2018
@StephaneDelcroix StephaneDelcroix deleted the fix-bugzilla-31171 branch May 8, 2018 07:34
@samhouts samhouts added the inactive Issue is older than 6 months and needs to be retested label Jun 7, 2019
@samhouts samhouts added a/performance i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often labels Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hartez hartez hartez approved these changes

@samhouts samhouts samhouts approved these changes

Assignees
No one assigned
Labels
a/performance e/4 🕓 4 i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often inactive Issue is older than 6 months and needs to be retested p/Android p/iOS 🍎 t/bug 🐛
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rmarinho @StephaneDelcroix @hartez @samhouts @kicsiede