New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix CommonStates.Focused issue #2158

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
4 participants
@P3PPP
Contributor

P3PPP commented Mar 21, 2018

Description of Change

Fixed incorrect modification of VisualState when the IsFocused property was updated.

Bugs Fixed

[VisualStateManager] "Focused" does not behave correctly. fixes #2157

API Changes

None.

Behavioral Changes

None.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts changed the title from Fixing bug #2157 CommonState.Focused issue. to [Core] Fix CommonState.Focused issue Mar 21, 2018

@samhouts samhouts added this to Ready in v3.1.0 via automation Mar 21, 2018

@samhouts samhouts changed the base branch from master to 3.0.0 Mar 21, 2018

@samhouts samhouts changed the base branch from 3.0.0 to master Mar 21, 2018

@samhouts

This comment has been minimized.

Member

samhouts commented Mar 21, 2018

Would you mind rebasing this PR on 3.0.0? Thanks!

@samhouts samhouts requested a review from hartez Mar 21, 2018

@StephaneDelcroix StephaneDelcroix changed the base branch from master to 3.0.0 Mar 21, 2018

@StephaneDelcroix StephaneDelcroix changed the base branch from 3.0.0 to master Mar 21, 2018

@StephaneDelcroix

seems legit.

@hartez ?

@samhouts samhouts moved this from Ready to In Review in v3.1.0 Mar 21, 2018

@P3PPP P3PPP changed the base branch from master to 3.0.0 Mar 22, 2018

@P3PPP P3PPP changed the title from [Core] Fix CommonState.Focused issue to [Core] Fix CommonStates.Focused issue Mar 22, 2018

@rmarinho rmarinho added the t/bug 🐛 label Mar 22, 2018

@rmarinho rmarinho added this to Ready in v3.0.0 via automation Mar 22, 2018

@rmarinho rmarinho removed this from In Review in v3.1.0 Mar 22, 2018

@rmarinho rmarinho moved this from Ready to In Review in v3.0.0 Mar 22, 2018

@rmarinho

UITest Bugzilla56298 is failing

@P3PPP

This comment has been minimized.

Contributor

P3PPP commented Mar 23, 2018

AutomationId is no match between definition("btnToggle") and test code("btnToogle") at Bugzilla56298.

@rmarinho

This comment has been minimized.

Member

rmarinho commented Mar 23, 2018

@P3PPP yap you right

@rmarinho rmarinho merged commit c4682e3 into xamarin:3.0.0 Mar 23, 2018

4 of 12 checks passed

VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS9 Validation UITests Finished
Details
VSTS: Xamarin Forms (PR Builds) Succeeded PR process
Details
VSTS: Xamarin Forms OSX PR-2158 - (1507777) succeeded
Details
VSTS: Xamarin Forms Windows VS2017 PR-2158 - (1507768) succeeded
Details
license/cla All CLA requirements met.

v3.0.0 automation moved this from In Review to Done Mar 23, 2018

@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018

@samhouts samhouts added the a/VSM label Nov 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment