Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Win] Setting TabbedPage.BarTextColor works #244

Merged
merged 1 commit into from Jul 18, 2016

Conversation

Projects
None yet
5 participants
@samhouts
Copy link
Member

commented Jul 2, 2016

Description of Change

Resolved known issues with the new BarTextColor feature for TabbedPages on Windows platforms.

Bugs Fixed

  • [WinRT, WinPhone 8.1, UWP] Setting BarTextColor does not currently work.
  • [WinPhone 8.1, UWP] If the TabbedPage contains a NavigationPage, the BarBackgroundColor and BarTextColor for the NavigationPage takes precedence
  • [WinPhone 8.1] If the TabbedPage contains a NavigationPage, switching between tabs may cause the background color to be lost.

API Changes

None

Behavioral Changes

  • [Win] Explicitly setting the BarTextColor and BarBackgroundColor to Color.Default will take precedence over the BarTextColor and BarBackgroundColor on NavigationPages. However, if the BarTextColor and BarBackgroundColor for the TabbedPage are never set, the NavigationPages may supply individual BarTextColors and BarBackgroundColors. This should preserve existing behavior while still allowing the TabbedPage to be the ultimate authority of bar color.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
[Win] Setting TabbedPage.BarTextColor works
[Win] TabbedPage BarBG takes precedence
@hartez

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

👍

1 similar comment
@jassmith

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2016

👍

@jassmith jassmith merged commit a490740 into master Jul 18, 2016

@samhouts samhouts deleted the bartext-win branch Jul 19, 2016

@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.