Skip to content

/Xamarin.Forms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Only reset ListView DataContext on INotifyCollectionChanged Reset #2453

Merged
merged 3 commits into from Apr 16, 2018

Conversation

@hartez
Copy link
Member

hartez commented Apr 13, 2018 •
edited by samhouts

Description of Change

UWP ListView's DataContext is being reset on every CollectionChanged event; this change limits those resets to NotifyCollectionChangedAction.Reset.

The relevant tests here are Issue1875 and Bugzilla57674 - the fix for 57674 (#1235) introduced the crash/regression.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@hartez
Only reset the data content for ListView on a Reset event; fixes #2332
Verified
This commit was signed with a verified signature.
hartez E.Z. Hart
GPG key ID: 1196DD903A2F7606 Learn about signing commits
Loading status checks…
9096593
@hartez hartez changed the title [UWP' [UWP] Only reset ListView DataContext on INotifyCollectionChanged Reset Apr 13, 2018
@hartez hartez changed the base branch from master to 3.0.0 Apr 13, 2018
@samhouts samhouts added this to Ready in v3.0.0 via automation Apr 13, 2018
@samhouts samhouts moved this from Ready to In Review in v3.0.0 Apr 13, 2018
@samhouts
samhouts approved these changes Apr 13, 2018
View changes
hartez added 2 commits Apr 13, 2018
@hartez
Merge branch '3.0.0' into fix-gh2332
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
f259ae2
@hartez
Fix formatting
Verified
This commit was signed with a verified signature.
hartez E.Z. Hart
GPG key ID: 1196DD903A2F7606 Learn about signing commits
Loading status checks…
1bbdd01
@rmarinho rmarinho merged commit e81f4c3 into 3.0.0 Apr 16, 2018
4 checks passed
4 checks passed
VSTS: Xamarin Forms (PR Builds) PR-2453 - (1590031) succeeded
Details
VSTS: Xamarin Forms OSX PR-2453 - (1590074) succeeded
Details
VSTS: Xamarin Forms Windows VS2017 PR-2453 - (1590039) succeeded
Details
license/cla All CLA requirements met.
v3.0.0 automation moved this from In Review to Done Apr 16, 2018
@hartez hartez deleted the fix-gh2332 branch May 4, 2018
@samhouts samhouts added this to the 3.0.0 milestone May 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhouts samhouts

Assignees
No one assigned
Labels
i/critical i/regression p/UWP
Projects
v3.0.0
  
Done
Milestone
  3.0.0
3 participants
@hartez @samhouts @rmarinho
You can’t perform that action at this time.