Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UWP] Fixed setting of properties to the CarouselPage #2547

Merged
merged 1 commit into from May 3, 2018
Merged

[UWP] Fixed setting of properties to the CarouselPage #2547

merged 1 commit into from May 3, 2018

Conversation

paymicro
Copy link
Contributor

@paymicro paymicro commented Apr 26, 2018

Description of Change

In tracker of CarouselPageRenderer a Container is defined

Bugs Fixed

Fixes #2127

API Changes

None

Behavioral Changes

When you set the CarouselPage properties, will no longer throw NRE exception

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts added this to In Review in v3.1.0 Apr 26, 2018
@pauldipietro pauldipietro added this to New in Triage Apr 26, 2018
@samhouts samhouts changed the title [UWP] Fixed setting of properties to the carousel page (#2127) [UWP] Fixed setting of properties to the CarouselPage Apr 30, 2018
@samhouts samhouts removed this from New in Triage Apr 30, 2018
@rmarinho rmarinho merged commit 80e2ea2 into xamarin:master May 3, 2018
v3.1.0 automation moved this from In Review to Done May 3, 2018
@paymicro paymicro deleted the fix-gh2127-CarouselPage branch May 4, 2018 11:07
@samhouts samhouts added this to Done in v3.6.0 May 4, 2018
@samhouts samhouts added this to the 3.1.0 milestone May 5, 2018
@samhouts samhouts removed this from Done in v3.6.0 May 7, 2018
@samhouts samhouts modified the milestone: 3.1.0 Jun 1, 2018
@samhouts samhouts added the p/UWP label Nov 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
v3.1.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants