Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows image loader error handling #260

Merged
merged 7 commits into from Jul 18, 2016

Conversation

@hartez
Copy link
Member

commented Jul 15, 2016

Description of Change

  • Improved error handling in WinRT/UWP ImageRenderer to catch and log exceptions from async loaders (instead of crashing application)
  • Background image loading failures now log errors instead of just doing nothing
  • ImageRenderer now waits until background image loading is finished before setting Image.IsLoading to false
  • More descriptive class name (ImageLoaderSourceHandler → UriImageSourceHandler)
  • UriImageSource now logs HTTP failures instead of just doing nothing

Bugs Fixed

  • Uncatchable exception from IImageSourceHandler derivatives resulting in application crash

API Changes

  • ImageSource constructor is now protected rather than internal (to allow for subclassing)

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
hartez added 4 commits Jul 14, 2016
hartez added 3 commits Jul 15, 2016
@jassmith

This comment has been minimized.

Copy link
Contributor

commented Jul 18, 2016

👍

1 similar comment
@samhouts

This comment has been minimized.

Copy link
Member

commented Jul 18, 2016

👍

@jassmith jassmith merged commit 2720337 into master Jul 18, 2016
2 checks passed
2 checks passed
Windows-Debug-Cycle6 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle 6 :: Windows Debug : Tests passed: 3375, ignored: 8
Details
Windows-Debug-Cycle7 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle7 :: Windows Debug : Tests passed: 3375, ignored: 8
Details
@samhouts samhouts deleted the windows-image-errorhandling branch Jul 19, 2016
jamesmontemagno referenced this pull request in jamesmontemagno/ImageCirclePlugin Sep 20, 2016
Fix breaking change in 2.3.2 for stream image source
@samhouts samhouts added this to the 2.3.2 milestone Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.