Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Remove Guid.NewGuid() calls from performance tracking #2791

Merged
merged 3 commits into from May 22, 2018

Conversation

samhouts
Copy link
Member

Description of Change

Unless there is a PerformanceProvider, we should not waste time creating a reference for the tracker.

Bugs Fixed

  • N/A

API Changes

Added parameter to internal Performance.Start method

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@samhouts samhouts added this to In Review in v3.0.0 May 21, 2018
@samhouts samhouts requested a review from jassmith May 21, 2018 22:09
@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label May 21, 2018
Copy link
Member

@StephaneDelcroix StephaneDelcroix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

reference = Interlocked.Increment(ref Reference).ToString();
Provider?.Start(reference, tag, path, member);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provider can't be null here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, yeah, I meant to change that

@xamarin-release-manager xamarin-release-manager added the API-change Heads-up to reviewers that this PR may contain an API change label May 22, 2018
@samhouts samhouts modified the milestones: 3.2.0, 3.0.0 May 22, 2018
@jassmith jassmith merged commit 3d01f09 into 3.0.0 May 22, 2018
v3.0.0 automation moved this from In Review to Done May 22, 2018
@samhouts samhouts added the t/housekeeping ♻︎ Internal only changes, won't be included in release notes label Jun 8, 2018
@samhouts samhouts deleted the perf-no-guid branch July 17, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-change Heads-up to reviewers that this PR may contain an API change t/housekeeping ♻︎ Internal only changes, won't be included in release notes
Projects
No open projects
v3.0.0
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants