Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A] PanGestureRecognizer will consistently send Completed event #313

Merged
merged 2 commits into from Aug 30, 2016

Conversation

@samhouts
Copy link
Member

commented Aug 23, 2016

Description of Change

Now sending the Completed event for Pan on Up event.

Bugs Fixed

API Changes

List all API changes here (or just put None), example:

Added:

  • Android: internal void InnerGestureListener.OnTouchEvent(MotionEvent e)

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
samhouts added 2 commits Aug 23, 2016
[A] Forward OnTouchEvent to Listener...
...and end scrolling on Up.

@samhouts samhouts changed the title [A] PanGestureRecognizer consistently sends Completed event [A] PanGestureRecognizer will consistently send Completed event Aug 23, 2016

@@ -8,33 +8,54 @@ namespace Xamarin.Forms.Controls
{
public class PanGestureGalleryPage : ContentPage
{
public class PanContainer : ContentView
public class PanCompleteArgs : EventArgs

This comment has been minimized.

Copy link
@rmarinho

rmarinho Aug 25, 2016

Member

I would prefer 1 class per file

pan.PanUpdated += (object s, PanUpdatedEventArgs e) =>
{
switch (e.StatusType) {
public class PanContainer : ContentView

This comment has been minimized.

Copy link
@rmarinho

rmarinho Aug 25, 2016

Member

Why is it a ContentView now ?

@jassmith jassmith merged commit ab0daa1 into master Aug 30, 2016

stefandevo added a commit to stefandevo/Xamarin.Forms that referenced this pull request Aug 31, 2016
Merge branch 'master' of https://github.com/xamarin/Xamarin.Forms
* 'master' of https://github.com/xamarin/Xamarin.Forms: (69 commits)
  Fix docs
  [Win] Fix FontAttributes unexpectedly changing a label's size (xamarin#325)
  [A] Check UserVisibleHint to prevent non-active tabs from firing SendAppearing in OnResume (xamarin#328)
  KeyboardExtensions is now public (xamarin#326)
  [A] PanGestureRecognizer will consistently send Completed event (xamarin#313)
  Use character truncation in Windows (xamarin#321)
  Fix for ListView BindingContext for Header/Footer (xamarin#312)
  Fix memory leak caused by BaseCellView and RendererHolder (xamarin#311)
  Update Makefile to support linux env (xamarin#309)
  Platform Specifics (xamarin#301)
  Throw InvalidOperationException if AppLinkEntry.Thumbnail source is invalid (xamarin#299)
  Allow Custom Android MapRenderers to override the default MapView options (xamarin#285)
  Fix crash when ItemsSource is set to null (xamarin#320)
  Fixed SinInOut description. (xamarin#319)
  Fix regression by adding null check in Windows ListView selection (xamarin#314)
  [Android] Fix for NullReferenceException when using the wrong activit… (xamarin#286)
  [WinRT] Remove preemptive setting of null upon action sheet closure (xamarin#305)
  [Xaml] Clone node tree on DT, allow markup to be evaluated multiple times (xamarin#295)
  [Windows] Correct enter/esc keypress behaviors for MessageDialog (xamarin#292)
  [iOS] Change when we updated the XF INavigationPageController after popping a page natively, Cleanup UITest references (xamarin#291)
  ...
JoonghyunCho pushed a commit to JoonghyunCho/Xamarin.Forms that referenced this pull request Sep 1, 2016
[A] PanGestureRecognizer will consistently send Completed event (xama…
…rin#313)

* Adjust gallery page for reproduction

* [A] Forward OnTouchEvent to Listener...

...and end scrolling on Up.

@samhouts samhouts deleted the fix-bugzilla39768 branch Sep 26, 2016

@samhouts samhouts added this to the 2.3.3 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.