Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fix TabbedPage crash when ItemsSource is set to null #320

Merged
merged 1 commit into from Aug 25, 2016

Conversation

@jimmgarrido
Copy link
Collaborator

commented Aug 25, 2016

Description of Change

When ItemsSource is set to null, CurrentPage also becomes null. This fix adds a check in TabbedPageRenderer on Android to prevent trying to scroll to a null CurrentPage and crashing.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Copy link

commented Aug 25, 2016

Hi @jimmgarrido, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@jassmith

This comment has been minimized.

Copy link
Contributor

commented Aug 25, 2016

👍

1 similar comment
@pauldipietro

This comment has been minimized.

Copy link
Member

commented Aug 25, 2016

👍

@jassmith jassmith merged commit 5b85aaf into xamarin:master Aug 25, 2016

stefandevo added a commit to stefandevo/Xamarin.Forms that referenced this pull request Aug 31, 2016
Merge branch 'master' of https://github.com/xamarin/Xamarin.Forms
* 'master' of https://github.com/xamarin/Xamarin.Forms: (69 commits)
  Fix docs
  [Win] Fix FontAttributes unexpectedly changing a label's size (xamarin#325)
  [A] Check UserVisibleHint to prevent non-active tabs from firing SendAppearing in OnResume (xamarin#328)
  KeyboardExtensions is now public (xamarin#326)
  [A] PanGestureRecognizer will consistently send Completed event (xamarin#313)
  Use character truncation in Windows (xamarin#321)
  Fix for ListView BindingContext for Header/Footer (xamarin#312)
  Fix memory leak caused by BaseCellView and RendererHolder (xamarin#311)
  Update Makefile to support linux env (xamarin#309)
  Platform Specifics (xamarin#301)
  Throw InvalidOperationException if AppLinkEntry.Thumbnail source is invalid (xamarin#299)
  Allow Custom Android MapRenderers to override the default MapView options (xamarin#285)
  Fix crash when ItemsSource is set to null (xamarin#320)
  Fixed SinInOut description. (xamarin#319)
  Fix regression by adding null check in Windows ListView selection (xamarin#314)
  [Android] Fix for NullReferenceException when using the wrong activit… (xamarin#286)
  [WinRT] Remove preemptive setting of null upon action sheet closure (xamarin#305)
  [Xaml] Clone node tree on DT, allow markup to be evaluated multiple times (xamarin#295)
  [Windows] Correct enter/esc keypress behaviors for MessageDialog (xamarin#292)
  [iOS] Change when we updated the XF INavigationPageController after popping a page natively, Cleanup UITest references (xamarin#291)
  ...
JoonghyunCho pushed a commit to JoonghyunCho/Xamarin.Forms that referenced this pull request Sep 1, 2016

@samhouts samhouts added this to the 2.3.3 milestone Jun 27, 2018

myroot added a commit to myroot/Xamarin.Forms that referenced this pull request Sep 9, 2019
[Tizen] Tizen renderer performance optimization (xamarin#320)
* Apply lazy loading for MD5 checksum (xamarin#316)

* Add API to set assemblies for custom renderer (xamarin#317)

* [Performance] Add prelaunching API (xamarin#315)

* Add prelaunch

* Apply lazy loading for MD5 checksum

* Apply preload systeminfo

* Revert "Apply lazy loading for MD5 checksum"

This reverts commit dfb9ff8c3bf6c55fb6ebcc583f974b7398d88f73.

* Refactoring preloading

* Revert "Add API to set assemblies for custom renderer (xamarin#317)" (xamarin#319)

This reverts commit 7d9f86a4456e7b9089411fc6e7eb6b905dd931d8.

* Fix naming

* Fix build error
rmarinho added a commit that referenced this pull request Sep 10, 2019
[Tizen] Tizen renderer performance optimization (#320) (#7440)
* Apply lazy loading for MD5 checksum (#316)

* Add API to set assemblies for custom renderer (#317)

* [Performance] Add prelaunching API (#315)

* Add prelaunch

* Apply lazy loading for MD5 checksum

* Apply preload systeminfo

* Revert "Apply lazy loading for MD5 checksum"

This reverts commit dfb9ff8c3bf6c55fb6ebcc583f974b7398d88f73.

* Refactoring preloading

* Revert "Add API to set assemblies for custom renderer (#317)" (#319)

This reverts commit 7d9f86a4456e7b9089411fc6e7eb6b905dd931d8.

* Fix naming

* Fix build error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.