Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS xf- Vendor Prefix #3276

Closed
wants to merge 2 commits into from

Conversation

@kingces95
Copy link
Member

commented Jul 11, 2018

Description of Change

Add Xamarin.Forms vendor specific css properties.

Implements #2891.

Issues Resolved

fixes #2891

API Changes

See the custom attributes applied to GreenVenderSpecificStyleSheetsAreApplied unit test.

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

Allows css binding to more XF BPs.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@kingces95 kingces95 force-pushed the cssvendorprefix branch 3 times, most recently from dd6f5e1 to 386442a Jul 11, 2018
@samhouts samhouts added this to In Progress in v3.6.0 Jul 11, 2018
@samhouts samhouts added this to In progress in Sprint 138 via automation Jul 11, 2018
@kingces95 kingces95 added the a/CSS label Jul 11, 2018
@kingces95 kingces95 changed the title css vendor prefix; gh 2891; raw impl to gather feedback css vendor prefix Jul 12, 2018
Copy link
Member

left a comment

left some comments. please add a code comment on the code you can not get to work

I'm unsure about placeholder and keyboard

using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-activityindicator-color", typeof(ActivityIndicator), nameof(ActivityIndicator.ColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

we need to reach an agreement about moving all the StyleProperties to the class (or interface) they apply to, or to keep them all in Properties.cs

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

You're the man. I swung this convention past @jassmith and he didn't have objection. However, I'm sure neither of us are wed to this convention. We'll just agree to do whatever you want.

I put them into the renderer file because the vender specific css property names are bound quite tightly to the renderer. This as opposed to the standard css names which work across many different renderers by binding to BPs in base classes.

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

leave it as is, for now, I'll think about it, and we'll rationalize later

using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-activityindicator-color", typeof(ActivityIndicator), nameof(ActivityIndicator.ColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

no need for a vendor-specific, use color

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

Can we map one css property to multiple BPs? For color, ActivityIndicator.ColorProperty is not the same as TextElement.TextColorProperty to which color is currently bound.

I ran the possibility of augmenting the loader to support one to many bindings but he nixed that idea in favor of a convention that didn't require changing the loader.

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 23, 2018

Member

we're doing that elsewhere, by defining an interface and a static class, so the ColorProperty is actually a shared instance

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

see e.g. ITextElement and TextElement

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

With one to many support this can now just be "color"

using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-boxview-color", typeof(BoxView), nameof(BoxView.ColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

See 1 css to many BP comment above.

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

color

using Xamarin.Forms.Internals;
using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-editor-text-color", typeof(Editor), nameof(Editor.TextColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

See 1 css to many BP comment above.

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

color

using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-editor-text-color", typeof(Editor), nameof(Editor.TextColorProperty))]
[assembly: StyleProperty("-xf-editor-placeholder", typeof(Editor), nameof(Editor.PlaceholderProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

we do not expose (yet) properties for setting the content (like text). I'd wait on this one.

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

No problem. Only added this because it was in the spec. Did I miss read the spec or is the spec ahead of it's time?

Technically, this works today, no? I mean, I specify some placeholder text and it'd be applied right? What feature is missing?

This comment has been minimized.

Copy link
@samhouts

samhouts Jul 18, 2018

Member

@kingces95 I think he means we can't yet set Text or Placeholder via CSS. When he says content, he's referring to the CSS content property. That'll be a complex one to map.

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

-xf-placeholder if it works

using Xamarin.Forms;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-inputview-max-length", typeof(InputView), nameof(InputView.MaxLengthProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

CSS doesn't expose max-length for a reason. we shouldn't either

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

No problemo. I only added it as it was in the spec. Did I read the spec wrong or is the spec wrong?

This comment has been minimized.

Copy link
@samhouts

samhouts Jul 18, 2018

Member

Spec is wrong

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 23, 2018

Member

Spec is wrong

I drafted the spec, and I agree

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

-xf-max-length

using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-inputview-max-length", typeof(InputView), nameof(InputView.MaxLengthProperty))]
[assembly: StyleProperty("-xf-inputview-keyboard", typeof(InputView), nameof(InputView.KeyboardProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

just like max-length, I don't think you can set the input attribute in CSS (but you can select based on it)

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

Again, no problemo. I only added it as it was in the spec. Did I read the spec wrong or is the spec wrong? Either way, the enum doesn't deserialize as specified in the spec. But that's a moot point if we're just gonna drop the thing anyway.

using Xamarin.Forms.Internals;
using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-progressbar-progress-color", typeof(ProgressBar), nameof(ProgressBar.ProgressColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

See 1 css to many BP comment above.

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

color

using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-navigationpage-bar-background-color", typeof(NavigationPage), nameof(NavigationPage.BarBackgroundColorProperty))]
[assembly: StyleProperty("-xf-navigationpage-bar-text-color", typeof(NavigationPage), nameof(NavigationPage.BarTextColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

drop the navigationpage

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

Sure thing. But I'll wait for @jassmith to sound off.

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

-xf-bar-background-color
-xf-bar-text-color

using Xamarin.Forms.Internals;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-stacklayout-spacing", typeof(StackLayout), nameof(StackLayout.SpacingProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 12, 2018

Member

this one is the first in which it make sense to have vendor-type-property

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 13, 2018

Author Member

Huh. Wonder why wasn't it included in the original spec and why the original spec has so many other ones specified... This one was requested in a comment from a customer.

This comment has been minimized.

Copy link
@samhouts

samhouts Jul 18, 2018

Member

@kingces95 I think he means that the naming convention is too verbose in most cases; it doesn't need the type because there's little chance of a conflicting property name.

This comment has been minimized.

Copy link
@StephaneDelcroix

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

-xf-spacing

@kingces95 kingces95 requested review from StephaneDelcroix and jassmith Jul 13, 2018
@samhouts samhouts moved this from In Progress to In Review in v3.6.0 Jul 13, 2018
@samhouts samhouts moved this from In progress to Ready for Review in Sprint 138 Jul 17, 2018
@kingces95 kingces95 force-pushed the cssvendorprefix branch from 24ce533 to d0300b0 Jul 17, 2018
@kingces95 kingces95 force-pushed the cssvendorprefix branch from 8bb600a to c49988b Jul 18, 2018
@samhouts samhouts changed the title css vendor prefix CSS xf- Vendor Prefix Jul 18, 2018
@@ -98,5 +100,146 @@ public void StyleSheetsOnAppAreApplied()
app.MainPage = page;
Assert.That((page.Content as Label).TextColor, Is.EqualTo(Color.Red));
}

public string ToVenderSpecificCss(Type type, string property)

This comment has been minimized.

Copy link
@samhouts

samhouts Jul 18, 2018

Member

Vender >> Vendor (throughout)

This comment has been minimized.

Copy link
@StephaneDelcroix
using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-activityindicator-color", typeof(ActivityIndicator), nameof(ActivityIndicator.ColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 23, 2018

Member

we're doing that elsewhere, by defining an interface and a static class, so the ColorProperty is actually a shared instance

using Xamarin.Forms;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-inputview-max-length", typeof(InputView), nameof(InputView.MaxLengthProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 23, 2018

Member

Spec is wrong

I drafted the spec, and I agree

[assembly: StyleProperty("-xf-visualelement-rotation-y", typeof(VisualElement), nameof(VisualElement.RotationYProperty))]
[assembly: StyleProperty("-xf-visualelement-scale", typeof(VisualElement), nameof(VisualElement.ScaleProperty))]
[assembly: StyleProperty("-xf-visualelement-scale-x", typeof(VisualElement), nameof(VisualElement.ScaleXProperty))]
[assembly: StyleProperty("-xf-visualelement-scale-y", typeof(VisualElement), nameof(VisualElement.ScaleYProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 23, 2018

Member

nope. should be transform

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

-xf-scale
-xf-rotation-x
etc etc etc

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 31, 2018

Member

I disagree here. should be transform

This comment has been minimized.

Copy link
@dansiegel

dansiegel Jul 31, 2018

Contributor

I have to agree with @jassmith. Something like -xf-visualelement-scale is completely undiscoverable and would limit the APIs use to industry experts. This needs to be stupid simple to figure out. Property names that make sense like -xf-scale achieve that.

//[assembly: StyleProperty("-xf-view-margin-left-property", typeof(View), nameof(View.MarginLeftProperty))]
//[assembly: StyleProperty("-xf-view-margin-top-property", typeof(View), nameof(View.MarginTopProperty))]
//[assembly: StyleProperty("-xf-view-margin-right-property", typeof(View), nameof(View.MarginRightProperty))]
//[assembly: StyleProperty("-xf-view-margin-bottom-property", typeof(View), nameof(View.MarginBottomProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

This comment has been minimized.

Copy link
@kingces95

kingces95 Jul 26, 2018

Author Member

Dropping.

@samhouts samhouts added this to In progress in Sprint 139 via automation Jul 23, 2018
@samhouts samhouts moved this from In progress to Ready for Review in Sprint 139 Jul 23, 2018
@kingces95

This comment has been minimized.

Copy link
Member Author

commented Jul 23, 2018

@samhouts thanks for the review! Will update per your comments after @jassmith weighs in. He and @StephaneDelcroix will reach a consensus as to which names should be exposed and how.

@@ -98,5 +100,146 @@ public void StyleSheetsOnAppAreApplied()
app.MainPage = page;
Assert.That((page.Content as Label).TextColor, Is.EqualTo(Color.Red));
}

public string ToVenderSpecificCss(Type type, string property)

This comment has been minimized.

Copy link
@StephaneDelcroix
using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-activityindicator-color", typeof(ActivityIndicator), nameof(ActivityIndicator.ColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

see e.g. ITextElement and TextElement

using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-activityindicator-color", typeof(ActivityIndicator), nameof(ActivityIndicator.ColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

leave it as is, for now, I'll think about it, and we'll rationalize later

using Xamarin.Forms.Internals;
using Xamarin.Forms.StyleSheets;

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

not required


//[assembly: StyleProperty("-xf-borderelement-border-color", typeof(BorderElement), nameof(BorderElement.BorderColorProperty))]

namespace Xamarin.Forms

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

not required

using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-searchbar-placeholder-color", typeof(SearchBar), nameof(SearchBar.PlaceholderColorProperty))]
[assembly: StyleProperty("-xf-searchbar-cancel-button-color", typeof(SearchBar), nameof(SearchBar.CancelButtonColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

see earlier comment about placeholder-color. cancel-button-color is related

using Xamarin.Forms.Internals;
using Xamarin.Forms.StyleSheets;

//[assembly: StyleProperty("-xf-span-background-color", typeof(Span), nameof(Span.BackgroundColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

not required

using Xamarin.Forms.Internals;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-stacklayout-spacing", typeof(StackLayout), nameof(StackLayout.SpacingProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix
using Xamarin.Forms.Platform;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-switch-on-color", typeof(XSwitch), nameof(XSwitch.OnColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

color

using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-tabbedpage-bar-background-color", typeof(TabbedPage), nameof(TabbedPage.BarBackgroundColorProperty))]
[assembly: StyleProperty("-xf-tabbedpage-bar-text-color", typeof(TabbedPage), nameof(TabbedPage.BarTextColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Jul 26, 2018

Member

oh, look, a similarity with NavigationPage. I think I see a pattern...

I wonder what could go wrong if we were unifying both ? in which scenario would they collide ? please discuss

This comment has been minimized.

Copy link
@jassmith

jassmith Jul 31, 2018

Contributor

-xf-bar-background-color
-xf-bar-text-color

@kingces95 kingces95 force-pushed the cssvendorprefix branch from c49988b to 2004544 Jul 26, 2018
using Xamarin.Forms.Internals;
using Xamarin.Forms.StyleSheets;

[assembly: StyleProperty("-xf-color", typeof(Span), nameof(Span.BackgroundColorProperty))]

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Aug 2, 2018

Member

color is already mapped to TextColorProperty, and background-color to BackgroundColorProperty

StephaneDelcroix added a commit that referenced this pull request Aug 2, 2018
map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891
@StephaneDelcroix StephaneDelcroix referenced this pull request Aug 2, 2018
2 of 3 tasks complete
StephaneDelcroix added a commit that referenced this pull request Aug 2, 2018
map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891
@kingces95

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2018

@StephaneDelcroix to take ownership and submit the PR. Possibly this branch, but not necessarily.

@kingces95 kingces95 closed this Aug 22, 2018
v3.6.0 automation moved this from In Review to Closed Aug 22, 2018
jassmith pushed a commit that referenced this pull request Aug 31, 2018
map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891
@samhouts samhouts added this to the 3.2.0 milestone Sep 11, 2018
@samhouts samhouts removed this from Closed in v3.6.0 Sep 11, 2018
@samhouts samhouts removed this from the 3.2.0 milestone Sep 12, 2018
@samhouts samhouts added this to the 3.3.0 milestone Sep 20, 2018
jfversluis added a commit to jfversluis/Xamarin.Forms that referenced this pull request Sep 24, 2018
* [C] VisibilityConverter Trims input (xamarin#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes xamarin#3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (xamarin#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (xamarin#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (xamarin#2589)"

This reverts commit f66a72d.

* Fix NRE; Ret 0 if Text null (xamarin#3594) fixes xamarin#3579

* [UWP, WPF] Fixes rendering of the main page (xamarin#2896) fixes xamarin#2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (xamarin#3605)

* [XamlC] Fix binding compilation fo value types (xamarin#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes xamarin#3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (xamarin#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (xamarin#3638)

* Add Null Check to GetRenderer (xamarin#3575)

- fix xamarin#3563

* Fix 3562 Null Reference Exception (xamarin#3576)

- fixes xamarin#3562

* Fix 3564 Null Reference Exception (xamarin#3578)

- fixes xamarin#3564

* [iOS] AutomationProperty support for cells (xamarin#3313) fixes xamarin#3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes xamarin#3188 (xamarin#3514)

* [Android] Use height when determining ScaledScreenSize; fixes xamarin#3609 (xamarin#3641)

* [C] Set binding context on Span Gestures (xamarin#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes xamarin#3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (xamarin#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (xamarin#3636)

* Add repro for xamarin#3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes xamarin#3049

* [Android] fixes xamarin#3675 - set  initial ScrollView Scroll values when RTL (xamarin#3676)

* [Android] API check for Shadow properties on Button (xamarin#3617) fixes xamarin#2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes xamarin#3525 - add epsilon for float compare (xamarin#3654)

* [iOS] fixes xamarin#3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (xamarin#3671) fixes xamarin#3634

* [GTK] Fix navigation bar visibility updates (xamarin#3651)

* Fix partially  xamarin#3585 (xamarin#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes xamarin#2894 - Gestures collection changes weren't correctly propagating (xamarin#3643)

* [iOS, UWP] fixes xamarin#2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes xamarin#3663 (xamarin#3684)

* Fix ScrollView Padding issue (xamarin#3685)

* [WPF] Memory leak when you pop a TabbedPage (xamarin#3372) fixes xamarin#3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (xamarin#3402) fixes xamarin#3343 fixes xamarin#3633

* Add repro for xamarin#3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes xamarin#3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (xamarin#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes xamarin#3276

- fixes xamarin#2891

* [iOS] Specify a default size for UISearchBar width if needed (xamarin#3635) fixes xamarin#3413 fixes xamarin#2139

* [Controls] Add reproduction and test case for issue xamarin#3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of xamarin#3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue xamarin#2139

* [UWP] Fixed double set margins in Layouts (xamarin#3570) fixes xamarin#3398 fixes xamarin#3616

* [Android] Support multiple clipping settings in single layout (xamarin#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (xamarin#3518)

* [Controls] Add repo of issue xamarin#3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (xamarin#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (xamarin#3723)

* [UITest] Update Xamarin.UITest nuget package (xamarin#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (xamarin#3746)

fixes xamarin#3705

* [Android, iOS] Fixes layout compression causes (xamarin#3698) fixes xamarin#3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (xamarin#3323)

* fixes xamarin#3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (xamarin#3653) fixes xamarin#2128 fixes xamarin#3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (xamarin#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (xamarin#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (xamarin#3761) fixes xamarin#3756

* [iOS] Fix NRE on ContextCell (xamarin#3714) fixes xamarin#3275

* [Controls] Add repo for issue xamarin#3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (xamarin#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (xamarin#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (xamarin#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (xamarin#3752)

-fixes xamarin#3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (xamarin#3792)

-fixes xamarin#3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (xamarin#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (xamarin#3835)

* [Core] Propagate BindingContext changes to TitleView (xamarin#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (xamarin#3786)

Drawing CornerRadius (introduce by xamarin#1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes xamarin#3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (xamarin#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (xamarin#3745)

* [Build] Fix merge

* Fix xamarin#3097 swipe gesture not being handled in VisualElementTracker. (xamarin#3098) Fixes xamarin#3097
jfversluis added a commit to jfversluis/Xamarin.Forms that referenced this pull request Sep 25, 2018
* [C] VisibilityConverter Trims input (xamarin#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes xamarin#3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (xamarin#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (xamarin#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (xamarin#2589)"

This reverts commit f66a72d.

* Fix NRE; Ret 0 if Text null (xamarin#3594) fixes xamarin#3579

* [UWP, WPF] Fixes rendering of the main page (xamarin#2896) fixes xamarin#2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (xamarin#3605)

* [XamlC] Fix binding compilation fo value types (xamarin#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes xamarin#3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (xamarin#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (xamarin#3638)

* Add Null Check to GetRenderer (xamarin#3575)

- fix xamarin#3563

* Fix 3562 Null Reference Exception (xamarin#3576)

- fixes xamarin#3562

* Fix 3564 Null Reference Exception (xamarin#3578)

- fixes xamarin#3564

* [iOS] AutomationProperty support for cells (xamarin#3313) fixes xamarin#3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes xamarin#3188 (xamarin#3514)

* [Android] Use height when determining ScaledScreenSize; fixes xamarin#3609 (xamarin#3641)

* [C] Set binding context on Span Gestures (xamarin#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes xamarin#3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (xamarin#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (xamarin#3636)

* Add repro for xamarin#3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes xamarin#3049

* [Android] fixes xamarin#3675 - set  initial ScrollView Scroll values when RTL (xamarin#3676)

* [Android] API check for Shadow properties on Button (xamarin#3617) fixes xamarin#2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes xamarin#3525 - add epsilon for float compare (xamarin#3654)

* [iOS] fixes xamarin#3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (xamarin#3671) fixes xamarin#3634

* [GTK] Fix navigation bar visibility updates (xamarin#3651)

* Fix partially  xamarin#3585 (xamarin#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes xamarin#2894 - Gestures collection changes weren't correctly propagating (xamarin#3643)

* [iOS, UWP] fixes xamarin#2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes xamarin#3663 (xamarin#3684)

* Fix ScrollView Padding issue (xamarin#3685)

* [WPF] Memory leak when you pop a TabbedPage (xamarin#3372) fixes xamarin#3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (xamarin#3402) fixes xamarin#3343 fixes xamarin#3633

* Add repro for xamarin#3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes xamarin#3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (xamarin#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes xamarin#3276

- fixes xamarin#2891

* [iOS] Specify a default size for UISearchBar width if needed (xamarin#3635) fixes xamarin#3413 fixes xamarin#2139

* [Controls] Add reproduction and test case for issue xamarin#3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of xamarin#3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue xamarin#2139

* [UWP] Fixed double set margins in Layouts (xamarin#3570) fixes xamarin#3398 fixes xamarin#3616

* [Android] Support multiple clipping settings in single layout (xamarin#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (xamarin#3518)

* [Controls] Add repo of issue xamarin#3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (xamarin#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (xamarin#3723)

* [UITest] Update Xamarin.UITest nuget package (xamarin#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (xamarin#3746)

fixes xamarin#3705

* [Android, iOS] Fixes layout compression causes (xamarin#3698) fixes xamarin#3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (xamarin#3323)

* fixes xamarin#3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (xamarin#3653) fixes xamarin#2128 fixes xamarin#3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (xamarin#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (xamarin#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (xamarin#3761) fixes xamarin#3756

* [iOS] Fix NRE on ContextCell (xamarin#3714) fixes xamarin#3275

* [Controls] Add repo for issue xamarin#3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (xamarin#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (xamarin#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (xamarin#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (xamarin#3752)

-fixes xamarin#3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (xamarin#3792)

-fixes xamarin#3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (xamarin#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (xamarin#3835)

* [Core] Propagate BindingContext changes to TitleView (xamarin#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (xamarin#3786)

Drawing CornerRadius (introduce by xamarin#1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes xamarin#3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (xamarin#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (xamarin#3745)

* [Build] Fix merge

* Fix xamarin#3097 swipe gesture not being handled in VisualElementTracker. (xamarin#3098) Fixes xamarin#3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (xamarin#3848) fixes xamarin#3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`
rmarinho added a commit that referenced this pull request Oct 25, 2018
…l bars (#3897) fixes #3843

* Update from origin (#8)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72d.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Implemented for iOS, Android and MacOS

* Implemented UAP and WPF

* Refactored duplicate code and removed typo in method name

* Update from origin (#9)

* [C] VisibilityConverter Trims input (#3581)

For CSS purposes, the VisibilityConverter was added, and actually
replaced the `Boolean.Parse(str)` call for parsing Visibility.
`Boolean.Parse()` trims input, and the converter was not, so this was a
regression.
This changes Trim() the input, to be fully backward compatible.

- fixes #3554

* Ensure ConstructorCountId and TimeId elements are available before querying them (#3588)

* For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)

This would allow previewer/designer/reloader to determine the source of a
stylesheet and refresh its content when appropriate.

* Revert "For consistency with ResourceDictionary, expose the Source for a StyleSheet (#2589)"

This reverts commit f66a72d.

* Fix NRE; Ret 0 if Text null (#3594) fixes #3579

* [UWP, WPF] Fixes rendering of the main page (#2896) fixes #2704

* [Core] Ignore Shamehat target when running DesignTimeBuild (#3605)

* [XamlC] Fix binding compilation fo value types (#3551)

properly load valuetype arguments of generated setters, using ldarg,
instead of ldarga.

- fixes #3539

* Update PULL_REQUEST_TEMPLATE.md

* Update PULL_REQUEST_TEMPLATE.md

* [Android] Fix Label LineHeight (#3452)

* fix line height android

* Make UAP respect initial LineHeight

* update .create-nuget.bat (#3638)

* Add Null Check to GetRenderer (#3575)

- fix #3563

* Fix 3562 Null Reference Exception (#3576)

- fixes #3562

* Fix 3564 Null Reference Exception (#3578)

- fixes #3564

* [iOS] AutomationProperty support for cells (#3313) fixes #3296

* [iOS] AutomationProperty support for cells

* Add test case to AutomationProperties gallery

* [UWP] Fix crash app when create navigation/tabbed page without children pages fixes #3188 (#3514)

* [Android] Use height when determining ScaledScreenSize; fixes #3609 (#3641)

* [C] Set binding context on Span Gestures (#3639)

* [Core] Set binding context on Span Gestures
* [Core] Simplify loop setting child binding context

- fixes #3524

* Update PULL_REQUEST_TEMPLATE.md

* [Android] remove deprecated AndroidUseLatestPlatformSdk (#3672)

* [iOS] iPad ActionSheet should always have a Cancel method (#3636)

* Add repro for #3049

* [iOS] iPad ActionSheet should always have a Cancel method

fixes #3049

* [Android] fixes #3675 - set  initial ScrollView Scroll values when RTL (#3676)

* [Android] API check for Shadow properties on Button (#3617) fixes #2702

* [Android] API check for Shadow properties on Button

* Fix swapped shadow values

* [iOS] fixes #3525 - add epsilon for float compare (#3654)

* [iOS] fixes #3525 - add epsilon for float compare and make region immutable

* [ControlGallery] spread out spans to account for click slop

* [ControlGallery] - adjust span slightly for android test

* [Core] remove private

* Fix text wrapping (#3671) fixes #3634

* [GTK] Fix navigation bar visibility updates (#3651)

* Fix partially  #3585 (#3592)

* Make webkit-sharp.dll.config cross-platform

* Update webkit-sharp.dll with missing signals bindings

see: https://github.com/ylatuya/webkit-sharp/tree/fluendo

* [iOS, UWP] fixes #2894 - Gestures collection changes weren't correctly propagating (#3643)

* [iOS, UWP] fixes #2894 - Gestures weren't wiring up to spans in all cases

* [Core] remove ChildGestureRecognizers when spans get removed

* [iOS] removed incorrect return from null

* Fixes #3663 (#3684)

* Fix ScrollView Padding issue (#3685)

* [WPF] Memory leak when you pop a TabbedPage (#3372) fixes #3267

* Fix [WPF] Memory leak when you pop a TabbedPage

* Update ViewRenderer.cs

* Update ViewRenderer.cs

* [Android,iOS,UWP] Allow Entry CursorPosition/SelectionLength to be set in ctor (#3402) fixes #3343 fixes #3633

* Add repro for #3343 + unit tests

* [Core] Disallow negative values for CursorPosition/SelectionLength

* [All] CursorPosition/SelectionLength can bindin ctor & clear value

fixes #3343

* typo

* cleanup

* [iOS] Cursor snaps to end

* try/catch

* [CSS] add more properties (#3466)

map new CSS properties:
- `color` on `IColorElement` (`ActivityIndicator`, `BoxView`),
  `ProgressBar` and `Switch`
- `row-gap` and `column-gap` on `Grid`
- `transform` and `transform-origin` on `VisualElement`
- `vertical-align` on `Label`

add new XF-specific CSS properties
- `-xf-placeholder` and `-xf-placeholder-color` on `Editor`, `Entry`,
  `SearchBar`
- `-xf-max-length` on `InputView` (`Editor` and `Entry`)
- `-xf-bar-background-color` and `-xf-bar-text-color` on
  `NavigationPage` and `TabbedPage`
- `-xf-orientation` on `ScrollView` and `StackLayout`
- `-xf-horizontal-scroll-bar-visibility` and
  `-xf-vertical-scroll-bar-visibility` on `ScrollView`
- `-xf-min-track-color`, `-xf-max-track-color` and `("-xf-thumb-color`
  on `Slider`
- `-xf-spacing` on `StackLayout`

This PR replaces and closes #3276

- fixes #2891

* [iOS] Specify a default size for UISearchBar width if needed (#3635) fixes #3413 fixes #2139

* [Controls] Add reproduction and test case for issue #3413

* [iOS] Don't use max value for iOS UISearchbar breaks on iOS 11.3

* [iOS] Force width value so we can renderer UISearchBar on iOS10 with infinite width

* [Controls] Fix spelling and add Manual Review to the test of #3413

* [iOS] Simplify code for UISearchBar width

* [iOS] Return always some width from measure the UISearchBar on IOS

* [Controls] Add reproduction case for issue #2139

* [UWP] Fixed double set margins in Layouts (#3570) fixes #3398 fixes #3616

* [Android] Support multiple clipping settings in single layout (#3559)

* Repro

* Fix for API 18+

*  [iOS] Unsubscribe CellPropertyChanged when SwitchCellRenderer is disposed (#3518)

* [Controls] Add repo of issue #3408

* [iOS] Unsubscribe CellPropertyChanged when cell is disposed

* [Controls] Add issue to project

* [iOS] Introduce CellPropertyChange to CellTableViewCell to used by all other cell renderers

* [Controls] Simplify Issue

* [iOS] Remove PropertyChanged that was not used

* [Controls] add check for null binding on template, add notes about issues

* [Controls] added reference to Android crash

* [iOS]Use existing PropertyChanged on ViewCelRenderer

* [iOS] Keep the existing override so we don't break users

* Update TextCellRenderer.cs

* update submodule

* 24H Mode (#3701)

The 24h mode for the pickerdialog was not working.

Version 3.1 was working fine. 

Here is an updated file.

* [UWP] uncomment tests that are now passing for 3188 (#3723)

* [UITest] Update Xamarin.UITest nuget package (#3632)

* [UITests] Update Xamarin.UITest 2.2.5

* [UITests] Try fix Toolbaritems

* [UITest] Update to 2.2.5-1606

* [UITests] Small Fixes and workarounds to make uitest happy

* [UITests ] Add delay to 1733 for API28

* [Android] Revert bad merge (#3746)

fixes #3705

* [Android, iOS] Fixes layout compression causes (#3698) fixes #3624

* [Android, iOS] Fixes layout compression causes

* [iOS] improve UpdateNewElement method

* Fix build error hopefully

* [UWP] Fixes CollectionChanged events in ListView (#3323)

* fixes #3273

* [UWP] Fixes CollectionChanged events in ListView

* a wrapped collection is used only if the SourceItem is not ObservableCollection

* improve uitest

* fixed NRE in empty ListView

* added a sortable custom renderer for UItest

* minor refactoring

* fixed reset of not wrapped collections

* addressing comments

* [UWP] remove WinRT hack

* [UWP] add missing using and cleanup additional resources

* [Android] Update Forms to remove API28 deprecated API (#3653) fixes #2128 fixes #3629

* [Build] Update provisioning

* [Controls] Ignore deprecated  Android API usage

* [Android] Remove use of obsolete color usage

* [Android] Remove app fragment usage

* [android] Rollback changes to EntryCellRenderer

* [Android] Better way to get the default color for the label text

* [Android] Obsolete message for ContentPage.CreateFragment()

* [ControlGallery] - create bitmap from Drawable to use for pixel location

* [Android] Use textcolor resource

* Update submodule

* Fix tests (#3771)

* [ControlGallery] Wait for element and add timing to tests

* [iOS] Fix NRE on RenderPool

* Add TabStop/TabIndex (#2795)

* [Core, UWP, Android] support TabStop/TabIndex

* removing linq

* add iOS / MacOS implementation

* add WPF implementation
fixes UWP implementation

* - addressing comments
- improve test
- optimizations
- added previous tab direction in same tab group

* addressing comments

* [Android] support tabstop for pickers

* - moving shared code to a static class
- removed reflection

* ITabStop -> changed to internal, renamed, added in to fastRenderers

* Update ITabStop to be public

* Fix : Binding Icon in ToolbarItem in TabbedPage doesn't refresh (#3761) fixes #3756

* [iOS] Fix NRE on ContextCell (#3714) fixes #3275

* [Controls] Add repo for issue #3275

* [iOS] Fix NRE when no gestures exist on table

* [iOS] Null check outside loop

* [iOS]Make sure to dispose/unhook when we are removed from UITableView.

* Update submodule

* [iOS] Don't double dispose ContextActionCell

* WPF - Fix Width and Height measurement when GetDesiredSize (#3750)

* WPF - Reset Width and Height when GetDesiredSize

* Some formatting changes

* Add APP directive

* [WPF]Fix build

* [Android Maps] Make markers available to subclasses (#3751)

* Make markers available to subclasses

* Fix build

* Use Find instead of FirstOrDefault

* [UITests] wait for element before querying for it (#3791)

* [UITests] wait for element before querying for it

* [Controls] generalize and better represent intended behavior

* WPF - Fix Local store not persistant when restarting App (#3752)

-fixes #3541
* WPF - Fix Local store not persistant when restarting App
* Add UITest
* [Controls] Add automated UI Test

* [UITests] Isolate test 3408

* [UITest] Update Xamarin UITest packages

* [UWP] implement Replace without reloading ListView (#3792)

-fixes #3788
* [UWP] implement Replace without reloading ListView
* [UWP] extract bindingcontext of new item for replace

* [iOS] Use UIApperance default color for UISwitch (#3819)

* [Controls] Set default color of UISwitch to Red

* [iOS] Use default color from Apperance API

* [UITests] replace awaits with more reliable WaitForElement (#3835)

* [Core] Propagate BindingContext changes to TitleView (#3823)

* [Core] Propagate BindingContext changes to TitleView

* [Tests] Move UI test to Core Unit Test

* [A] do not draw gradient for empty CornerRadius (#3786)

Drawing CornerRadius (introduce by #1998) when the CornerRadii are
actually 0 causes scaling artifacts on API < 25.

This fixes the regression when no CornerRadius is set. Expect blurry
border scaling with CornerRadius not empty and API < 25

- fixes #3781

* [Android] Fix WebView.Navigating event, make WebViewClient inheritable (#3780)

* Extracted WebViewRenderer.WebClient to FormsWebViewClient, moved SendNavigating call from ShouldOverrideUrlLoading to OnPageStarted

* Changed _webViewClient and GetWebViewClient() method to return base class

* Changed public things to protected internal

* Fix spaces to tabs indentation to match the coding style (#3745)

* [Build] Fix merge

* Fix #3097 swipe gesture not being handled in VisualElementTracker. (#3098) Fixes #3097

* Ensure that the ListViewAdapter is no longer being used by the ListVi… (#3848) fixes #3603

* Ensure that the ListViewAdapter is no longer being used by the ListView before disposing it

* Remove `RemoveAllViews` from `Dispose`

* Fixed code review comments

* Removed obsolete convert method

* Making sure default platform functionality is intact iOS and Android

As er code review comments

* Making sure default platform functionality is intact MacOS

* Making sure default platform functionality is intact UWP and WPF

* Code review comments for iOS, Android and MacOS

Default platform value is now preserved and applied when setting is set to default

* Code review comments UWP and WPF

* Fix build

* [UITest] - add ui test to test scroll permutations

* [Uwp] fix bad merge

* [wpf] fix spacing
jfversluis added a commit to jfversluis/Xamarin.Forms that referenced this pull request Nov 6, 2018
* [Android] Enable MaxLines and TextDecorations on fast renderers (xamarin#3878)

* enable MaxLines on fast renderers

* added text decoration functionality

* include test in project

* [Enhancement] Create a bindable property for AutomationId (xamarin#3879)

* create a bindable property for automationId

* make ClassId and AutomationId properties of Element

* add comments to .create-nuget.bat

* added preserve attribute (xamarin#3876) fixes xamarin#2306

* [Core] Moving Command's CanExecuteChanged to use the WeakEventManager (xamarin#3852) fixes xamarin#3656

* [Core]  Use WeakEventManager on CanExecuteChanged

* [Core]Add unit test for remove event handler with WeakEventManager

* [Core] Fix remove the correct handler

* [CSS] accept 'oblique' for 'font-style' (xamarin#3815) fixes xamarin#3808

- fixes xamarin#3808

* Prevent double time/date picker dialogs on Android when setting focus (xamarin#3899)

* Prevent double time/date picker dialogs on Android when setting focus (xamarin#3899)

* [Controls] Fix merge remove duplciated issue 3788

* WPF - Fix Unable to intercept back button (xamarin#3762)

* WPF - Fix Unable to intercept back button

* WPF - Improve OnBackButtonPressed

-fixes xamarin#3689

* Fix Bugzilla38723 (xamarin#3812)

fixes xamarin#2302

* [C] fix css mapping (xamarin#3919)

* [Android] Fix UI test 1851 (xamarin#3882)

* add preserve attribute

- fixes xamarin#2255


* added using System

* fixed spacing

* use TestContentPage

* fixed scope issues

* [Android] Make native Android Platforms accessible via Context (xamarin#3364)

* Make native Android Platforms accessible via Context

* Add null checks

* Added a disabled look to Android Toolbar Item images. (xamarin#3773)

* Added a disabled look to Android Toolbar Item images.

* Update NavigationPageRenderer.cs

Refactored DisabledToolbarAlpha into a constant as requested.

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper (xamarin#3896)

* [UWP] fixes tabstops of TimePicker, DatePiker. SearchBar, Stepper

* common code moved to VisualElementRenderer

* rename interface

fixes xamarin#3872

* [UWP] For the Slider default value of step is set to 1000 to match Android. (xamarin#3141)

* WPF - Ctrl+A does not select all in WPF password Entry (xamarin#3908)

* [WPF] Fix Height of items not consistent (xamarin#3925) fixes xamarin#3913

* Fix StartTimer and Ticker for UWP (xamarin#3911)

- fixes xamarin#1937

* Apply font fix for button and span (xamarin#3907)

* added instructions (xamarin#3891)

- fixes xamarin#2361

* [Android] Convert corner radius with correct pixel density (xamarin#3893) fixes xamarin#3884

* [Controls] Add Issue xamarin#3884 repo

* [Android] Convert  corner radius with correct pixel density fixes xamarin#3884

* [Controls] Update test message

* WPF - Fix TimePicker with short time pattern shows verbose time (xamarin#3924)

* Fix UI test 39378 (xamarin#3928)

fixes xamarin#2305

* Update ClipBounds when View bounds changes (xamarin#3909)

fixes xamarin#3717

* [C] catch AmbiguousMatchException on GetProps (xamarin#3915)

- fixes xamarin#3870

* Automate UI test B45702 (xamarin#3914) fixes xamarin#2389

* automate 45702

* fix indentation

* Fix bugzilla60787 (xamarin#3933)

* [Android]Fix for frame renderer's bug (bugzilla 60787).

xamarin#3902
https://bugzilla.xamarin.com/show_bug.cgi?id=60787
xamarin#3902

* Add control to repro

* PR fix

* Build fix

* Build fix for Xamarin.Forms.Core.Android.UITests

* added instructions (xamarin#3926)

* [UWP] fixes flyout menu on cell item (xamarin#3682)

* Fix UI test B41424 needs instructions (xamarin#3942)

* Add manual test steps and checks for ui test

* step4Label text fix

* [iOS] fix full width issues for TitleView (xamarin#3939)

* [iOS] fix full width issues for TitleView

* [iOS] simplified iOS 10

fixes xamarin#3881
fixes xamarin#3679

* Changes in TableView GTK Control to allow refresh the content (xamarin#3941)

- fixes xamarin#3725

* Only set the Page Padding via SafeAreaInset on iOS (xamarin#3811)

* only set the Page Padding via SafeAreaInset on iOS
-fixes xamarin#3809

* [Controls] add waits for clicks in ui tests

* [Controls] remove wrong category

* [iOS] Move inset logic down into ios renderer

* Added logic to allow set the ListView SelectedIndex (xamarin#3948) fixes xamarin#3766

* Automate UI test 35127 (xamarin#3927)

* automate test
- fixes xamarin#2262
* indentation fix
* indentation fix 2

* Make GetIconDrawable virtual (xamarin#3967)

By making GetIconDrawable virtual for the Android TabbedPageRenderer it allows for the icon to come from other sources (like glyph fonts). This will work for both top and bottom tabs.

* [GTK] Fix visibility of hidden pages in the stack (xamarin#3904)

When navigating to a new page, we should hide the previous
content and show the new one so that the previous page
renderer is not taken in account for redraws and resizes

* [Android] If MaxLines is not explicitly set, let LineBreakMode handle it (xamarin#3936)

* [Android] If MaxLines is not explicitly set, all LineBreakMode to set it;
if MaxLines is explicitly set, MaxLines setting wins. Use a more reasonable
default for native MaxLines when handling it via LineBreakMode. Consolidate
MaxLines handling code between legacy and fast renderers. Remove unnecessary
setting of SingleLine (which only applies to input).
- fixes xamarin#3772

* Remove unnecessary maxLines setting

* Handle resetting MaxLines to -1/default

* Reinstate workaround for array bounds exception in older Android APIs

* Fix UI test B43941 (xamarin#3889)

* Add all platforms and remove non-deterministic behaviour

* Return back correct check of counter

* Endline fix

* remove childPages list

* [XamlC] avoid multiple subscription (xamarin#3969)

Avoid multiple subscription to PropertyChanged on TypedBindings

- fixes xamarin#3613
- fixes xamarin#3650

* Fix typos (mainly 'toogle' becoming 'toggle') (xamarin#3975)

* Fix Issue2597 Needs UI Test (xamarin#3966)

* Add test for issue 2597

* Fix space

* Add CODEOWNERS

* Fix PanGesture inside scroll issue https://github.com/xamarin/Xamarin… (xamarin#3842)

* Fix PanGesture inside scroll issue xamarin#3840
- fixes xamarin#3840
* fixe formatting

* [UITest] added UI Test

* [Controls] adjusted UI Test button positions

* [UITEST]  simplify UI tests

* [C] add CSS mapping for max-lines (xamarin#3991)

- fixes xamarin#3982

* [iOS] Add ability to turn off updates to native controls from another thread (xamarin#3774)

* [iOS] Add ability to turn off updates to native controls from another thread

* Flip evaluation order

fixes xamarin#1755

* Fixed NotImplementedException refreshing items in WPF ListView (xamarin#3962)

* Fixed NotImplementedException refreshing items in WPF ListView

* Small changes in ListView events subscription

fixes xamarin#3309
fixes xamarin#3737
fixes xamarin#3648

* [GTK] Fix transparent background in visual elements (xamarin#3744)

* Fix ActivityIndicator.IsRunning state (xamarin#4007)

* add pdb for uap into nuget (xamarin#4015)

* update GitInfo

* [XamlC] don't compile bindings with Source (xamarin#3978)

Sources are usually x:reference that can't be resolved at compilation
time.

- fixes xamarin#3606

* [Xaml[C]] resolve Extensions first (xamarin#3977)

XamlLoader should first look for type with the Extension suffix. It used
to be the case, but somehow regressed.

- fixes xamarin#3606 (comment)

* [UWP] Document in the README.md the steps required to run UI Tests (xamarin#4014) fixes xamarin#3984

* [Tizen] Add TabIndex implement for Tizen renderer (xamarin#4046)

* [Tasks] multitarget the build tasks (xamarin#3895)

- fixes xamarin#2690
- closes xamarin#2706

* [UITests] Update TestCloud.Agent (xamarin#4055)

* [Tizen] Fix ProjectGuid for Forwarders (xamarin#4063)

* [Tizen] Fix ProjectGuid for Forwarders

* [Tizen] Make sure not to generate dependency file

* Correct minor typo (xamarin#4068)

* Added WebView Reload (xamarin#4013) fixes xamarin#3776

* Added WebView Reload

* WebView Reload Added Tizen suport

* [Tizen] Cleanup Code (xamarin#4080)

* fixed ios editor placeholder font (xamarin#4009)

* Prevented crash