Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[C, Xaml] add SizeTypeConverter #3381

Merged
merged 1 commit into from Jul 31, 2018
Merged

[C, Xaml] add SizeTypeConverter #3381

merged 1 commit into from Jul 31, 2018

Conversation

StephaneDelcroix
Copy link
Member

@StephaneDelcroix StephaneDelcroix commented Jul 23, 2018 •
edited

Description of Change

Add a missing TypeConverter attribute to Size struct.

Issues Resolved

API Changes

/

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

/

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added this to In Review in v3.2.0 Jul 23, 2018
@StephaneDelcroix
[C, Xaml] add SizeTypeConverter
e6d8dca 
Add a missing TypeConverter attribute to Size struct.

- fixes #3280
@StephaneDelcroix StephaneDelcroix merged commit 2c65c03 into 3.2.0 Jul 31, 2018
v3.2.0 automation moved this from In Review to Done Jul 31, 2018
@StephaneDelcroix StephaneDelcroix deleted the fix-3280 branch July 31, 2018 08:26
@samhouts samhouts added this to the 3.2.0 milestone Aug 13, 2018
@GalaxiaGuy GalaxiaGuy mentioned this pull request Aug 30, 2018
Closed
@samhouts samhouts modified the milestone: 3.2.0 Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samhouts samhouts samhouts approved these changes

Assignees
No one assigned
Labels
a/Xaml </> e/1 🕐 1 t/bug 🐛
Projects
No open projects
v3.2.0
  
Done
Milestone
3.2.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@StephaneDelcroix @samhouts