Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Implemented SelectedTintColor and UnselectedTintColor for iOS #3519

Closed
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jfversluis
Copy link
Contributor

jfversluis commented Aug 9, 2018

Description of Change

Through the PlatformSpecific API it is now possible to set the selected and unselected tint item on iOS.
The unselected item color is only supported on iOS 10 and higher.

API Changes

Added:

  • TabbedPage.On().GetUnselectedTintColor();
  • TabbedPage.On().GetSelectedTintColor();

Platforms Affected

  • iOS

Behavioral/Visual Changes

This does not change anything when upgraded as-is. Only when the user leverages this functionality they will see the desired colors in the tab bar on iOS.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

jfversluis added some commits Jun 6, 2018

Merge pull request #3 from xamarin/master
Merge from origin
Merge pull request #4 from xamarin/master
Merge from origin
Merge pull request #5 from xamarin/master
New changes from origin
Merge pull request #6 from xamarin/master
Update from origin

@jfversluis jfversluis changed the title Implemented SelectedTintColor and UnselectedTintColor for iOS [iOS] Implemented SelectedTintColor and UnselectedTintColor for iOS Aug 9, 2018

@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Aug 9, 2018

So this is similar to pr #2050

I wonder if it's best we try to implemente this for all platforms as it's a very requested feature.

@samhouts samhouts added this to In Review in vCurrent (3.6.0) Aug 9, 2018

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Aug 10, 2018

I agree. Just after creating this I thought the same thing. Unify the API and make it available for as much of the platforms as possible.

Although it is similar to the PR you mentioned, that is for the ListView, right? The concept is the same but implementation totally different. Or did you just mean in terms of how it should/could work?

@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Aug 10, 2018

Oh right sorry, when I read the the title I was think this PR was LIstVIew I know see is for TabbedPage

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Aug 10, 2018

But other than that. Do we want to get this in de non-platform specific APIs? Seems to make sense.

@rmarinho
Copy link
Member

rmarinho left a comment

@jfversluis ideally this would be for 3 paltforms and be on core, selected and unselected color of the tab , we would need to investigate if that's possible, also needs to be implemented without breaking existing apps. If not we would be good to accept this just for iOS for now after some changes.

if (Tabbed == null || TabBar == null || TabBar.Items == null)
return;

if (SelectedTintColor != Color.Default)

This comment has been minimized.

@rmarinho

rmarinho Aug 17, 2018

Member

what if you want to return to the default color? you will need to save the default color of the platform and use it when the Color is set to Default. and had change before.

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Aug 18, 2018

I totally agree, let me close this one and rethink if we can do it in a shared way.

@jfversluis jfversluis closed this Aug 18, 2018

vCurrent (3.6.0) automation moved this from In Review to Closed Aug 18, 2018

@jfversluis jfversluis deleted the jfversluis:feature/3478 branch Jan 4, 2019

@samhouts samhouts removed this from Closed in vCurrent (3.6.0) Feb 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.