Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tizen] Support the TitleView of NavigationPage #3536

Merged
merged 1 commit into from Aug 17, 2018
Merged

[Tizen] Support the TitleView of NavigationPage #3536

merged 1 commit into from Aug 17, 2018

Conversation

yourina
Copy link
Contributor

@yourina yourina commented Aug 10, 2018 •
edited

Description of Change

This change is about supporting the TitleView of NavigationPage on Tizen

titleview_mobile

Issues Resolved

None

API Changes

None

Platforms Affected

  • Tizen

Behavioral/Visual Changes

If you set any View of Xamarin.Forms to the navigation bar of a NavigationPage, TitleView would be shown on top of Page.
However, If pages are pushed before the TitleView is set, these pages can not display the TitleView due to the platform limitation.
It is recommend to set the TitleView before pushing a Page.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard

@samhouts samhouts added this to In Review in v3.6.0 Aug 10, 2018
rookiejava
rookiejava approved these changes Aug 14, 2018
View reviewed changes
Copy link
Collaborator

@rookiejava rookiejava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixes #1716

@rmarinho rmarinho merged commit 0d6559c into xamarin:master Aug 17, 2018
v3.6.0 automation moved this from In Review to Done Aug 17, 2018
@samhouts samhouts added this to the 3.3.0 milestone Sep 20, 2018
@samhouts samhouts removed this from Done in v3.6.0 Sep 21, 2018
@samhouts samhouts added this to Done in v3.4.0 Sep 21, 2018
@samhouts samhouts removed this from Done in v3.4.0 Nov 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rookiejava rookiejava rookiejava approved these changes

Assignees
No one assigned
Labels
p/Tizen
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yourina @rookiejava @rmarinho @samhouts