Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Android: WebView - Control over Zoom controls #3607

Merged
merged 10 commits into from Feb 12, 2019

Conversation

@jfversluis
Copy link
Contributor

jfversluis commented Aug 18, 2018

Description of Change

For Android users now have the ability to enable zooming on the WebView. It can be done only by gestures, or by also showing the zoom controls.

Automated UI tests are not included since I don't think it's possible to test. I did include two unit tests for the setting and retrieving the values of these methods.

Issues Resolved

API Changes

Added:

  • WebView.On().EnableZoomControls(true/false);
  • WebView.On().DisplayZoomControls(true/false);

Platforms Affected

  • Android

Behavioral/Visual Changes

The default behavior is as it was, no zooming and no zoom controls are visible. When setting EnableZoomControls to true just zooming, the user is now able to zoom the WebView by using gestures. When also enabling DisplayZoomControls, the Android default zoom controls are shown.

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Sep 21, 2018

Anything I still need to do here? 🙂

@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Dec 5, 2018

Can you rebase on top of master @jfversluis ? thanks

@jfversluis jfversluis requested a review from StephaneDelcroix as a code owner Dec 5, 2018

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Dec 5, 2018

Done!

@samhouts
Copy link
Member

samhouts left a comment

Maybe for extra credit, you could fix the other platform specifics in the WebView.cs file to use the FormsElement alias, too. :)

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Jan 15, 2019

Hm, if only there was an "accept all suggestions" to not have all kinds of commits... :D

Done!

@samhouts samhouts moved this from In Review to In Progress in vCurrent (3.6.0) Jan 15, 2019

@samhouts

This comment has been minimized.

Copy link
Member

samhouts commented Jan 31, 2019

@jfversluis Would you mind rebasing this on master again? I'd like to get a clean run of the tests, but a hiccup in our CI system requires a rebase. Sorry about that! Thank you!

jfversluis and others added some commits Dec 20, 2018

Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/WebVi…
…ew.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>
Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/WebVi…
…ew.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>
Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/WebVi…
…ew.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>
Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/WebVi…
…ew.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>
Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/WebVi…
…ew.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>
Update Xamarin.Forms.Core/PlatformConfiguration/AndroidSpecific/WebVi…
…ew.cs

Co-Authored-By: jfversluis <github@geraldversluis.nl>

@jfversluis jfversluis force-pushed the jfversluis:feature/1661-webview-zoom branch from 9cf6734 to 1e989a9 Jan 31, 2019

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Jan 31, 2019

@samhouts no problem! Just did!

@samhouts samhouts added this to In Progress in vNext (4.0.0) Feb 2, 2019

@samhouts samhouts removed this from In Progress in vCurrent (3.6.0) Feb 2, 2019

@samhouts

This comment has been minimized.

Copy link
Member

samhouts commented Feb 7, 2019

@jfversluis GitHub was listening!
image

@jfversluis

This comment has been minimized.

Copy link
Contributor Author

jfversluis commented Feb 7, 2019

Hahaha awesome! 😄 In that case, if they are listening I should probably think of some more things!

Anything I need to do on the failing tests here?

@rmarinho rmarinho merged commit 2c3df0a into xamarin:master Feb 12, 2019

11 of 13 checks passed

VSTS: Android API28 Validation Fast Renderers UITests Finished
Details
Xamarin Forms Build scheduled in AzureDevOps
Details
VSTS: Android API19 Validation Fast Renderers UITests Finished
Details
VSTS: Android API19 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API23 Validation Fast Renderers UITests Finished
Details
VSTS: Android API23 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API25 Validation Fast Renderers UITests Finished
Details
VSTS: Android API25 Validation Legacy Renderers UITests Finished
Details
VSTS: Android API28 Validation Legacy Renderers UITests Finished
Details
VSTS: iOS10 Validation UITests Finished
Details
VSTS: iOS11 Validation UITests Finished
Details
VSTS: iOS12 Validation UITests Finished
Details
license/cla All CLA requirements met.
Details

vNext (4.0.0) automation moved this from In Progress to Done Feb 12, 2019

@jfversluis jfversluis deleted the jfversluis:feature/1661-webview-zoom branch Feb 12, 2019

@samhouts samhouts added this to Done in vNext+1 (master) Mar 2, 2019

@samhouts samhouts removed this from Done in vNext (4.0.0) Mar 2, 2019

@samhouts samhouts added this to the 4.0.0 milestone Mar 8, 2019

@samhouts samhouts removed this from Done in vNext+1 (master) Mar 11, 2019

@samhouts samhouts added this to Done in vNext (4.0.0) Mar 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.