New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A] Check for ViewStates.Gone in AppCompat TabbedPageRenderer #365

Merged
merged 1 commit into from Sep 30, 2016

Conversation

Projects
None yet
5 participants
@pauldipietro
Member

pauldipietro commented Sep 16, 2016

Description of Change

The use of ViewStates.Gone was not being taken into account when calculating the tab height in OnLayout in the AppCompat TabbedPageRenderer and as a result was always taking up space in the layout when it shouldn't be.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=43108

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Sep 17, 2016

Contributor

I can confirm this change fixes the issue. Thanks!

Contributor

adrianknight89 commented Sep 17, 2016

I can confirm this change fixes the issue. Thanks!

@jassmith jassmith merged commit f1689cf into master Sep 30, 2016

3 of 4 checks passed

iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Exit code 1
Details
Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 346, ig…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3437, ignored: 8
Details

@rmarinho rmarinho deleted the fix-bugzilla43108 branch Jun 22, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment