Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
iOS and Android timers should be runnable from any thread and execute… #374
Description of Change
This PR ensures that device timer can be started from any thread and executed on the UI thread. For a detailed discussion, see https://bugzilla.xamarin.com/show_bug.cgi?id=22706 and http://forums.xamarin.com/discussion/comment/74535
Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
The Windows code is here:
It looks correct to me. There is a WindowsTimer internal class right after StartTimer, and that internal class appears to be unused. Seems like a good candidate for deletion, but maybe I'm not searching in the right place.
There are similar _Timer classes in Android and iOS, and I'm not sure whether those are used or not. They're built on the .Net Timer class, which bothers me.