New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change appearance of NSTabView #375

Closed
wants to merge 95 commits into
base: macOS
from

Conversation

Projects
None yet
3 participants
@ailen0ada
Copy link

ailen0ada commented Sep 24, 2016

Description of Change

Image property of NSSegmentedControl requests 19x19 pixels image strictly.
Control won't resize the image whether small or large.
https://developer.apple.com/library/content/documentation/UserExperience/Conceptual/OSXHIGuidelines/ToolbarIcons.html#//apple_ref/doc/uid/20000957-CH89-SW1

This is differ from behavior and image specification of UITabBar in iOS.

Bugs Fixed

  • None

API Changes

  • None

Behavioral Changes

Appearance of page items placed on the top of TabbedPage will change from segmented button to toolbar.

Before:
before
After:
after

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Copy link

dnfclas commented Sep 24, 2016

Hi @ailen0ada, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@ailen0ada ailen0ada changed the title Set Toolbar to TabView.TabStyle Change appearance of NSTabView Sep 24, 2016

@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Sep 24, 2016

Thanks for the PR, i changed because of issues with the NavigationPage where we need to add and manage a NSToolbar, Also i checked some applications and they most use the segmented control version.

@jassmith what do you like more ?

My idea is this is a virtual method one could override in a custom renderer if they want.

@rmarinho rmarinho force-pushed the xamarin:macOS branch 2 times, most recently from dc5d182 to 6a2bc45 Sep 28, 2016

@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Oct 3, 2016

what if we resize the image ?

@ailen0ada

This comment has been minimized.

Copy link

ailen0ada commented Oct 3, 2016

Resize the image before control appears would be nice.
I'm not enough thought about NavigationPage.
Thank you for considering.

@rmarinho

This comment has been minimized.

Copy link
Member

rmarinho commented Oct 3, 2016

I added the resize of the icon image, it now looks fine, you can override in a custom renderer if you want.

@rmarinho rmarinho closed this Oct 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment