[C] specify type and default value for native bindings #376

Merged
merged 1 commit into from Sep 26, 2016

Conversation

Projects
None yet
5 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Sep 24, 2016

Description of Change

When creating the BP proxy, create it with the right type, and use the default value of the target property as default value for the BP

Bugs Fixed

  • fix binding to TextBlock.Text on UWP (you can't set Text to null)

Behavioral Changes

It's been a long time since I've sent any PR during weekend. I think it classifies as a behavioral change. I'm quite interested about the final results of that transformation. It'll probably end up with the kids getting 2 xmas gifts.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@jassmith jassmith merged commit 16295a3 into master Sep 26, 2016

4 of 5 checks passed

iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 4, …
Details
Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests passed: 346, ig…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3452, ignored: 8
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 342,…
Details

@StephaneDelcroix StephaneDelcroix deleted the fix-nullnativebindings branch Jan 31, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment