New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xaml] more primitive types #385

Merged
merged 2 commits into from Sep 27, 2016

Conversation

Projects
None yet
4 participants
@StephaneDelcroix
Member

StephaneDelcroix commented Sep 27, 2016

Description of Change

Support additional builtin conversions for: sbyte, uhort, uint, ulong and decimal

Support additional Xaml2009 Language Primitives for <x:SByte/>, <x:UInt16/>, <x:UInt32/> and, wait for it, <x:UInt64/>.

Those primitives aren't part of the Xaml2009 specification (https://msdn.microsoft.com/en-us/library/ee792002(v=vs.110).aspx). We can now argue that the spec is wrong, and our implementation is right.

Bugs Fixed

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@StephaneDelcroix StephaneDelcroix changed the title from Xaml more primitive types to [Xaml] more primitive types Sep 27, 2016

@jassmith jassmith merged commit 3e0ee96 into master Sep 27, 2016

3 of 5 checks passed

Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Exit code 1 (new)
Details
iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Exit code 255 (new)
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Running
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests passed: 342,…
Details

@StephaneDelcroix StephaneDelcroix deleted the xaml_morePrimitiveTypes branch Jan 31, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment