Minimum width and height should work #386
Description of Change
If request is 100x100 and minimum is 300x300, Math.Min always sets minimum to 100x100; thus, ignoring user-set minimum dimensions.
The unit test is there to make sure setting minimum dimensions does not inadvertently change request.
I have not verified all, but since they are related to minimum dimensions, they might all be fixed.
Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
@jassmith How do you hope to fix those issues then? Will
IMO, devs should be informed so that they fix any breaking changes.
Can we add a check to look at XF version ID so that new apps use the fixed version? I know this would create clutter in the code base. Just an idea.
@jassmith I ran 13 different tests on an Android button with my code changes:
Only one produces incorrect result. This is because of the way
All unit tests pass.
I'd still test my code on your end unless you have a strong reason (please explain) not to do so. Right now, minimum size request does not work at all.