New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinRT] Fix MDP and TabbedPage Appearing/Disappearing #387

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
4 participants
@pauldipietro
Member

pauldipietro commented Sep 27, 2016

Description of Change

MasterDetailPage and TabbedPage in WinRT were only firing off the Appearing event once and not firing off Disappearing at all due to OnUnloaded being called after Dispose, always causing the PageController value to be null. If this is instead called before SetElement(null) in Dispose it allows the Appearing/Disappearing events to work as expected.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=40408

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@rmarinho

I think you can't remove the UnLoaaded , when a page is still in the stack it can disappear but not be disposed.

@pauldipietro

This comment has been minimized.

Show comment
Hide comment
@pauldipietro

pauldipietro Sep 27, 2016

Member

Good point. Those are back in place and just using the similar call should still resolve the original issue.

Member

pauldipietro commented Sep 27, 2016

Good point. Those are back in place and just using the similar call should still resolve the original issue.

@samhouts samhouts merged commit d5f4aeb into master Oct 11, 2016

2 of 5 checks passed

Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests failed: 1, pass…
Details
iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 14 …
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests failed: 1, p…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3456, ignored: 8
Details

@samhouts samhouts deleted the fix-bugzilla40408 branch Oct 11, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment