Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A] PanGestureRecognizer will consistently send Started/Move event #389

Merged
merged 2 commits into from Oct 4, 2016

Conversation

@samhouts
Copy link
Member

commented Sep 27, 2016

Description of Change

Continuation of #313. Now sending the Started/Running events for Pan on Move event, which will allow Pan to function after a long press is detected without having to lift your finger. Previously, a long press would swallow the Scroll event, which gave the appearance that the Pan did not work when dragging very slowly.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
samhouts added 2 commits Sep 27, 2016

@samhouts samhouts force-pushed the fix-bugzilla39768-2 branch from 80dbbb8 to db8b032 Sep 28, 2016

@rmarinho

This comment has been minimized.

Copy link
Member

commented Oct 3, 2016

UITest failing are expected..

@jassmith jassmith merged commit c83c19f into master Oct 4, 2016

2 of 5 checks passed

Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests failed: 1, pass…
Details
iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 5, …
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests failed: 1, p…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3456, ignored: 8
Details
rmarinho added a commit that referenced this pull request Oct 4, 2016
[A] PanGestureRecognizer will consistently send Started/Move event (#389
)

* Add reproduction for Bugzilla 39768

* [A] Handle onTouchEvent MOVE

@rmarinho rmarinho deleted the fix-bugzilla39768-2 branch Oct 4, 2016

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.