Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Android] ScrollView should send correct ScrollX and ScrollY #394
Description of Change
This should send the final
While testing horizontal + vertical scrolling, I discovered a bug.
Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
changed the title from
[Android] ScrollView should send correct ScrollX and ScrollY
Sep 29, 2016
referenced this pull request
Oct 18, 2016
@samhouts I made improvements so we monitor changes during flight instead of only looking at final values.
Do you accept UI tests not associated with bugs? The idea is to write tests based on expectations in order to hopefully prevent future regression. If so, where would they be placed?
Dec 6, 2016
Hey @adrianknight89 this test is failing on CI on all iOS version
Failing for Ipad Air iOS 9
Failing for iPhone 6 plus on iOS 8
Failing for Iphone 6 on iOS 10
Also if i run in my sim i don't get the 100 100 values we are expecting when clicking.
I m reverting this PR for now..