Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[iOS] Tab children should be cast to Page #398
Description of Change
This fixes an internal bug and is also a discussion.
Just wondering, why did you decide to hide
This PR should still be merged because I fixed a casting error. If you comment
or reinitialize the array in a custom renderer, then
Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.
If i m not mistaken we have some issues when reorder and using NavigationPages, so it's unsupported scenario, we can move this to a virtual method, to be easier to override, something like ConfigureTabVie, i m doing something similar in MacOS, and since we introduce a virtual for CreateNativeControl we could do one for ConfigureNativeControl for these kind of settings.. This could also be a platform specific feature .
about this failure this seems to be a issue in refactoring, good catch, this code wasn't being called but it would crash.