New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] Entry should correctly update Text when typing aid is used #401

Merged
merged 5 commits into from Oct 20, 2016

Conversation

Projects
None yet
6 participants
@adrianknight89
Contributor

adrianknight89 commented Sep 30, 2016

Description of Change

iOS Entry does not correctly update its Text property when typing aid system is used. This is a limitation of how EditingChanged works rather than XF but can be worked around.

Steps to test this PR:

  1. Turn on auto-correct

  2. Type omw // each character should raise EditingChanged

  3. Hit return key or tap outside the bounds of Entry // does not raise EditingChanged event

  4. EditingEnded works around the issue

  5. Turn on auto-correct

  6. Type omw // each character should raise EditingChanged

  7. Hit space key or tap the suggestion // raises EditingChanged

  8. Default behavior works

Bugs Fixed

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Sep 30, 2016

Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Sep 30, 2016

Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@campersau campersau referenced this pull request Oct 14, 2016

Closed

Fix Text value on Entry after autocorrect #455

0 of 4 tasks complete

@jassmith jassmith merged commit 6f00e07 into xamarin:master Oct 20, 2016

0 of 3 checks passed

Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Tests failed: 1, pass…
Details
iOS10-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10 : Tests failed: 5, …
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests failed: 1, p…
Details
@jgold6

This comment has been minimized.

Show comment
Hide comment
Contributor

jgold6 commented Nov 17, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment