Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WinRT] Fix regression on ListView selection with enter key #402

Merged
merged 1 commit into from Sep 30, 2016

Conversation

@pauldipietro
Copy link
Member

commented Sep 30, 2016

Description of Change

In PR #241 some code was added for allowing ListView selection via the enter key. After the first selection was made with the key, it appeared that subsequent selections via mouse would cause a double firing of ItemSelected. This code can just be handled inside the OnKeyPressed method instead to prevent this.

Bugs Fixed

https://bugzilla.xamarin.com/show_bug.cgi?id=44886

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

@jassmith jassmith merged commit 97bc024 into master Sep 30, 2016

2 of 4 checks passed

Android-UITests Started TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
iOS9-UITests Started TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3456, ignored: 8
Details
@samhouts samhouts referenced this pull request Feb 23, 2017
4 of 4 tasks complete

@rmarinho rmarinho deleted the fix-bugzilla44886 branch Jun 22, 2017

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.