Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C] Allow recursive parts of binding path #4028

Merged
merged 1 commit into from Nov 21, 2018

Conversation

@StephaneDelcroix
Copy link
Member

commented Oct 7, 2018

Description of Change

[C] Allow recursive parts of binding path

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

PR Checklist

  • Has automated tests
  • Rebased on top of the target branch at time of PR
  • Changes adhere to coding standard
@StephaneDelcroix

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2018

I'm not happy with this solution. do not merge

@StephaneDelcroix

This comment has been minimized.

Copy link
Member Author

commented Oct 8, 2018

by that, I mean if someone binds to BindingContext.BindingContext.BindingContext.BindingContext.Title we might end up with too many property changed subscriptions

@samhouts samhouts added this to In Progress in v3.4.0 Oct 8, 2018

@StephaneDelcroix

This comment has been minimized.

Copy link
Member Author

commented Nov 18, 2018

But the alternatives are even less sane. let's go with this

@StephaneDelcroix StephaneDelcroix changed the base branch from 3.3.0 to 3.4.0 Nov 18, 2018

@samhouts samhouts moved this from In Progress to In Review in v3.4.0 Nov 19, 2018

@StephaneDelcroix StephaneDelcroix changed the base branch from 3.4.0 to master Nov 20, 2018

@samhouts samhouts added this to In Review in v3.6.0 Nov 20, 2018

@samhouts samhouts removed this from In Review in v3.4.0 Nov 20, 2018

@StephaneDelcroix StephaneDelcroix merged commit b2d7a4e into master Nov 21, 2018

2 checks passed

Xamarin Forms #PR-4028 - (2223865) succeeded
Details
license/cla All CLA requirements met.
Details

v3.6.0 automation moved this from In Review to Done Nov 21, 2018

@StephaneDelcroix StephaneDelcroix deleted the fix_gh3994 branch Nov 21, 2018

@samhouts samhouts added this to the 4.0.0 milestone Dec 4, 2018

@samhouts samhouts removed this from Done in v3.6.0 Jan 3, 2019

@samhouts samhouts modified the milestones: 4.0.0, 3.5.0 Jan 10, 2019

@samhouts samhouts added this to Done in v3.5.0 Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.