New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Windows] Fix crash when toggling IsPassword on multiple Entry controls #405

Merged
merged 2 commits into from Oct 11, 2016

Conversation

Projects
None yet
4 participants
@jimmgarrido
Collaborator

jimmgarrido commented Sep 30, 2016

Description of Change

A System.ArgumentException was being thrown when trying to set the InputScope on a subsequent Entry control to PasswordInputScope.

It looks like the sameInputScope cannot be applied to multiple elements so this fix makes PasswordInputScope not static, which allows each Entry control to initialize its own if needed.

A similar report about this issue can be seen in the last few replies in this thread.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
Member

StephaneDelcroix commented Oct 5, 2016

@samhouts

Should be pretty easy to write a test for this one.

@StephaneDelcroix StephaneDelcroix merged commit caa3816 into xamarin:master Oct 11, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment