Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CreateNativeControl virtual instead of abstract #406

Merged
merged 1 commit into from Oct 3, 2016

Conversation

@jassmith
Copy link
Contributor

commented Oct 1, 2016

Description of Change

Make CreateNativeControl virtual instead of abstract

Bugs Fixed

None

API Changes

Nothing in core. Android ViewRenderer now has default impl of CreateNativeControl

Behavioral Changes

Old renderers which dont use this method no longer crash.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense

Fixes backwards compatibility issue.

Jason Smith
Make CreateNativeControl virtual instead of abstract
Fixes backwards compatibility issue.

@rmarinho rmarinho merged commit 4f8af14 into master Oct 3, 2016

2 of 4 checks passed

Android-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1 : Exit code 255 (new)
Details
iOS9-UITests Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9 : Tests failed: 1, p…
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3456, ignored: 8
Details

@rmarinho rmarinho deleted the CreateNativeViewVirtual branch Oct 3, 2016

rmarinho added a commit that referenced this pull request Oct 4, 2016

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.