New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Internal keyboard hide/show should handle null views #418

Merged
merged 8 commits into from Oct 24, 2016

Conversation

Projects
None yet
6 participants
@adrianknight89
Contributor

adrianknight89 commented Oct 5, 2016

Description of Change

Internal HideKeyboard throws an NRE when the view passed is null. In most cases, the view should be set, but I've run into situations where this wasn't true (extension methods do not care if the owner is null or not). The method should be able to handle null references. At the moment, I'm not sure if it should return immediately or throw a NullReferenceException.

The same can be said of ShowKeyboard.

No tests provided since the methods are internal.

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Oct 5, 2016

Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

dnfclas commented Oct 5, 2016

Hi @adrianknight89, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@jassmith

This comment has been minimized.

Show comment
Hide comment
@jassmith

jassmith Oct 20, 2016

Member

Yeah it should throw an ArgumentNullException

Member

jassmith commented Oct 20, 2016

Yeah it should throw an ArgumentNullException

@kingces95

This comment has been minimized.

Show comment
Hide comment
@kingces95

kingces95 Oct 20, 2016

Member

Will change return to throw ArgumentNullException and submit new PR and close this one.

Member

kingces95 commented Oct 20, 2016

Will change return to throw ArgumentNullException and submit new PR and close this one.

@adrianknight89

This comment has been minimized.

Show comment
Hide comment
@adrianknight89

adrianknight89 Oct 20, 2016

Contributor

I can update this one here. Why create a new PR?

Contributor

adrianknight89 commented Oct 20, 2016

I can update this one here. Why create a new PR?

@kingces95

This comment has been minimized.

Show comment
Hide comment
@kingces95

kingces95 Oct 21, 2016

Member

Thanks, we we're gonna do it for you but you beat us to it.

Member

kingces95 commented Oct 21, 2016

Thanks, we we're gonna do it for you but you beat us to it.

@kingces95

This comment has been minimized.

Show comment
Hide comment
@kingces95

kingces95 Oct 21, 2016

Member

👍

Member

kingces95 commented Oct 21, 2016

👍

@rmarinho rmarinho merged commit 6196407 into xamarin:master Oct 24, 2016

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment