New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OnIdiom support for Desktop (UWP) #420

Merged
merged 1 commit into from Oct 11, 2016

Conversation

Projects
None yet
5 participants
@activa
Contributor

activa commented Oct 5, 2016

Description of Change

The current implementation for OnIdiom is missing the Desktop property. When running in a Windows UWP "desktop" app, it always returns the Phone property.

API Changes

List all API changes here (or just put None), example:

Added:

  • Desktop property to OnIdiom

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
OnIdiom support for Desktop (UWP)
The current implementation for OnIdiom<T> is missing the Desktop property. When running in a Windows UWP "desktop" app, it always returns the Phone property.
@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Oct 5, 2016

Hi @activa, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dnfclas commented Oct 5, 2016

Hi @activa, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

@StephaneDelcroix

This misses the part where the TargetPlatform is actually set on UWP Desktop.

@activa

This comment has been minimized.

Show comment
Hide comment
@activa

activa Oct 6, 2016

Contributor

@StephaneDelcroix What do you mean? The target is set to Desktop in Xamarin.Forms/Xamarin.Forms.Platform.WinRT.Tablet/Forms.cs

Device.Idiom = TargetIdiom.Desktop;

Line 52

Contributor

activa commented Oct 6, 2016

@StephaneDelcroix What do you mean? The target is set to Desktop in Xamarin.Forms/Xamarin.Forms.Platform.WinRT.Tablet/Forms.cs

Device.Idiom = TargetIdiom.Desktop;

Line 52

@StephaneDelcroix

This comment has been minimized.

Show comment
Hide comment
@StephaneDelcroix

StephaneDelcroix Oct 6, 2016

Member

@activa my wrong, I misread.

Member

StephaneDelcroix commented Oct 6, 2016

@activa my wrong, I misread.

@dnfclas

This comment has been minimized.

Show comment
Hide comment
@dnfclas

dnfclas Oct 6, 2016

@activa, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

dnfclas commented Oct 6, 2016

@activa, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@dnfclas dnfclas added the cla-signed label Oct 6, 2016

@StephaneDelcroix StephaneDelcroix merged commit ec09d75 into xamarin:master Oct 11, 2016

@activa activa deleted the activa:patch-1 branch Oct 11, 2016

@Depechie

This comment has been minimized.

Show comment
Hide comment
@Depechie

Depechie Mar 13, 2017

Contributor

Not liking the implementation of the DetectPlatform method for UWP.
When you app runs in continuum mode on a windows phone, the OnIdiom will still return Phone as result, although your design will need to render itself as a desktop app.
Meaning the whole check is rendered mute.

Contributor

Depechie commented Mar 13, 2017

Not liking the implementation of the DetectPlatform method for UWP.
When you app runs in continuum mode on a windows phone, the OnIdiom will still return Phone as result, although your design will need to render itself as a desktop app.
Meaning the whole check is rendered mute.

@samhouts samhouts added this to the 2.3.4 milestone Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment