Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[A] Prevent blank page from appearing when MainPage is switched #421

Merged
merged 5 commits into from Oct 6, 2016

Conversation

@samhouts
Copy link
Member

commented Oct 6, 2016

Description of Change

On Android, delay disposal of PageRenderers to prevent a blank screen from appearing when the MainPage is switched to a MasterDetailPage containing a TabbedPage or NavigationPage. Also removing animation from above scenario.

Test is included, but must be uncommented in the App.cs.

Bugs Fixed

API Changes

None

Behavioral Changes

None

PR Checklist

  • Has tests (if omitted, state reason in description)
  • Rebased on top of master at time of PR
  • Changes adhere to coding standard
  • Consolidate commits as makes sense
samhouts and others added 3 commits Oct 5, 2016

var renderersToDispose = _navModel.Roots.Select(Android.Platform.GetRenderer).ToList();

Device.StartTimer(TimeSpan.FromSeconds(1), () =>

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Oct 6, 2016

Member

There's one thing I like more than magic numbers: MAGIC STRINGS ! :)

This comment has been minimized.

Copy link
@jamesl77

jamesl77 Oct 6, 2016

I wish the code had more comments for scenarios like this. Why 1 seconds. Why not 100 milliseconds.

This comment has been minimized.

Copy link
@StephaneDelcroix

StephaneDelcroix Oct 6, 2016

Member

@jamesl77 the code usually have comments when we do magic

This comment has been minimized.

Copy link
@samhouts

samhouts Oct 6, 2016

Author Member

It also wasn't meant to be our permanent solution. It was intentionally exaggerated and submitted for our UI tests to run through to see what sort of side effects it might cause. 😄

samhouts added 2 commits Oct 6, 2016
@samhouts

This comment has been minimized.

Copy link
Member Author

commented Oct 6, 2016

@StephaneDelcroix Please review again when you can. Thanks!

@jassmith jassmith merged commit ba6caad into master Oct 6, 2016

2 of 5 checks passed

Android-UITests Started TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run Android 6.0.1
Details
iOS10-UITests Started TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS10
Details
iOS9-UITests Started TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: UI Tests :: OSX Test Cloud Package - Run iOS Unified iOS9
Details
OSX-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: OSX Debug : Running
Details
Windows-Debug-C8 Finished TeamCity Build Xamarin.Forms :: Debug :: Cycle8 :: Windows Debug : Tests passed: 3456, ignored: 8
Details
jassmith pushed a commit that referenced this pull request Oct 6, 2016
[A] Prevent blank page from appearing when MainPage is switched (#421)
* repro

* [A]Add horrible hack to prevent background flashing when swapping MainPage

* cleanup repro

* Revert "[A]Add horrible hack to prevent background flashing when swapping MainPage"

This reverts commit d0fdc38.

* [A] E.Z.'s less magical but just as effective solution

@samhouts samhouts deleted the fix-bugzilla44596 branch Oct 7, 2016

@samhouts samhouts modified the milestones: 2.3.4, 2.3.3 Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.